From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode Date: Mon, 15 Feb 2016 11:45:59 +0530 Message-ID: <56C16D1F.7060601@ti.com> References: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> Sender: netdev-owner@vger.kernel.org To: "David Rivshin (Allworx)" , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, David Miller , Nicolas Chauvet List-Id: linux-omap@vger.kernel.org On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes, > and silently handled any other values as if MII was specified. In a > case where the PHY mode was incorrectly specified, or a bug elsewhere, > there would be no indication of a problem. If MII was the correct mode, > then this will go unnoticed, otherwise the symptom will be a failure > to transmit/receive data over the RMII/RGMII link. > > Add a dev_warn() to make this condition obvious and provide a > breadcrumb to follow. > > Cc: Mugunthan V N > Signed-off-by: David Rivshin Acked-by: Mugunthan V N Regards Mugunthan V N From mboxrd@z Thu Jan 1 00:00:00 1970 From: mugunthanvnm@ti.com (Mugunthan V N) Date: Mon, 15 Feb 2016 11:45:59 +0530 Subject: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> References: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> Message-ID: <56C16D1F.7060601@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes, > and silently handled any other values as if MII was specified. In a > case where the PHY mode was incorrectly specified, or a bug elsewhere, > there would be no indication of a problem. If MII was the correct mode, > then this will go unnoticed, otherwise the symptom will be a failure > to transmit/receive data over the RMII/RGMII link. > > Add a dev_warn() to make this condition obvious and provide a > breadcrumb to follow. > > Cc: Mugunthan V N > Signed-off-by: David Rivshin Acked-by: Mugunthan V N Regards Mugunthan V N From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode Date: Mon, 15 Feb 2016 11:45:59 +0530 Message-ID: <56C16D1F.7060601@ti.com> References: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , David Miller , Nicolas Chauvet To: "David Rivshin (Allworx)" , Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:37760 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbcBOGRA (ORCPT ); Mon, 15 Feb 2016 01:17:00 -0500 In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Saturday 13 February 2016 06:15 AM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes, > and silently handled any other values as if MII was specified. In a > case where the PHY mode was incorrectly specified, or a bug elsewhere, > there would be no indication of a problem. If MII was the correct mode, > then this will go unnoticed, otherwise the symptom will be a failure > to transmit/receive data over the RMII/RGMII link. > > Add a dev_warn() to make this condition obvious and provide a > breadcrumb to follow. > > Cc: Mugunthan V N > Signed-off-by: David Rivshin Acked-by: Mugunthan V N Regards Mugunthan V N