From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/HVM: fold hypercall tables
Date: Mon, 15 Feb 2016 08:26:45 +0000
Message-ID: <56C18BC5.8000509@citrix.com>
References: <56C18F7D02000078000D1E93@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <amc96@hermes.cam.ac.uk>) id 1aVEUc-0005XO-OJ
	for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 08:26:50 +0000
In-Reply-To: <56C18F7D02000078000D1E93@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 15/02/2016 07:42, Jan Beulich wrote:
> @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg
>          }
>  #endif
>  
> -        regs->_eax = hvm_hypercall32_table[eax](ebx, ecx, edx, esi, edi, ebp);
> +        regs->_eax = hypercall_table[eax].compat(ebx, ecx, edx, esi, edi, ebp);
>  

I know its in a different translation unit, but we already have a
hypercall_table and it is a global symbol.  Please could we retain the
hvm_ prefix here.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>