All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Martin Koegler <martin.koegler@chello.at>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] Provide sequencer sound card number / PID	via alsa-lib
Date: Mon, 15 Feb 2016 11:39:13 +0100	[thread overview]
Message-ID: <56C1AAD1.70307@ladisch.de> (raw)
In-Reply-To: <1455370937-501-1-git-send-email-martin@mail.zuhause>

Martin Koegler wrote:
> +++ b/src/seq/seq.c
>  /**
> + * \brief Get the sound card number (kernel) or owning PID
> + * \param info client_info container
> + * \return card number/PID/-1 if value is not available.
> + */

Please document that card/pid are valid only for clients of type
SND_SEQ_KERNEL/USER_CLIENT.

And I think two functions for card and pid are more appropriate.


Regards,
Clemens

  parent reply	other threads:[~2016-02-15 10:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13 13:42 [PATCH] Provide sequencer sound card number / PID via alsa-lib Martin Koegler
2016-02-13 13:42 ` [PATCH] Show sequencer sound card numer/PID via aconnect Martin Koegler
2016-02-13 13:42 ` [PATCH] Provide card number / PID via sequencer client info Martin Koegler
2016-02-15 10:30   ` Takashi Iwai
2016-02-15 10:37     ` Clemens Ladisch
2016-02-15 18:32     ` Martin Koegler
2016-02-15 19:08       ` Takashi Iwai
2016-02-15 21:44         ` Martin Koegler
2016-02-15 22:34           ` Takashi Iwai
2016-02-16  8:03             ` Martin Koegler
2016-02-16  8:41               ` Takashi Iwai
2016-02-16  8:59                 ` Clemens Ladisch
2016-02-16  9:27                   ` Takashi Iwai
2016-02-16 18:21                     ` Martin Koegler
2016-02-17 14:07                       ` Takashi Iwai
2016-02-17 21:30                         ` Martin Koegler
2016-02-15 10:39 ` Clemens Ladisch [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-03 21:39 [PATCH] Provide sequencer sound card number / PID via alsa-lib Martin Koegler
2016-02-12 18:57 Martin Koegler
2016-02-13 12:36 ` Takashi Sakamoto
2016-02-13 12:45   ` Martin Koegler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C1AAD1.70307@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=martin.koegler@chello.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.