From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v4 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC) Date: Mon, 15 Feb 2016 11:55:21 +0000 Message-ID: <56C1BCA9.9010802@intel.com> References: <1454095171-22475-1-git-send-email-david.s.gordon@intel.com> <1454095171-22475-3-git-send-email-david.s.gordon@intel.com> <20160130105627.GQ24534@nuc-i3427.alporthouse.com> <20160130112818.GV24534@nuc-i3427.alporthouse.com> <56AF2935.1040409@intel.com> <20160211084715.GH11240@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 096826E132 for ; Mon, 15 Feb 2016 11:55:25 +0000 (UTC) In-Reply-To: <20160211084715.GH11240@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTEvMDIvMTYgMDg6NDcsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gTW9uLCBGZWIgMDEs IDIwMTYgYXQgMDk6NDU6MjVBTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IE9uIDMwLzAx LzE2IDExOjI4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBPbiBTYXQsIEphbiAzMCwgMjAxNiBh dCAxMDo1NjoyN0FNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+Pj4gT24gRnJpLCBKYW4g MjksIDIwMTYgYXQgMDc6MTk6MjdQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+Pj4+IDEu IGFkZCBjYWxsIHRvIGk5MTVfZ2VtX2NvbnRleHRfZmluaSgpIHRvIGRlYWxsb2NhdGUgdGhlIGRl ZmF1bHQKPj4+Pj4gICAgIGNvbnRleHQocykgaWYgdGhlIGNhbGwgdG8gaW5pdF9yaW5ncygpIGZh aWxzLCBzbyB0aGF0IHdlIGRvbid0Cj4+Pj4+ICAgICBsZWFrIHRoZSBjb250ZXh0IGluIHRoYXQg c2l0dWF0aW9uLgo+Pj4+Pgo+Pj4+PiAyLiByZW1vdmUgdXNlbGVzcyBjb2RlIGluIGludGVsX2xv Z2ljYWxfcmluZ19jbGVhbnVwKCksIHByZXN1bWFibHkKPj4+Pj4gICAgIGNvcHlwYXN0ZWQgZnJv bSBsZWdhY3kgcmluZ2J1ZmZlciB2ZXJzaW9uIGF0IGNyZWF0aW9uLgo+Pj4+Pgo+Cj4gSWYgeW91 ciBjb21taXQgbWVzc2FnZSBoYXMgYSBsaXN0IG9mIGluZGVwZW5kZW50IGNoYW5nZXMgLi4uCj4K Pj4+Pj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNv bT4KPj4+Pj4gLS0tCj4+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgfCAg NSArKysrLQo+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMTAgKyst LS0tLS0tLQo+Pj4+PiAgIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA5IGRlbGV0 aW9ucygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+Pj4gaW5kZXggYTky ODgyMy4uNWE0ZDQ2OCAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+Pj4+ IEBAIC00OTg2LDggKzQ5ODYsMTEgQEAgaW50IGk5MTVfZ2VtX2luaXQoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPj4+Pj4gICAJCWdvdG8gb3V0X3VubG9jazsKPj4+Pj4KPj4+Pj4gICAJcmV0ID0g ZGV2X3ByaXYtPmd0LmluaXRfcmluZ3MoZGV2KTsKPj4+Pj4gLQlpZiAocmV0KQo+Pj4+PiArCWlm IChyZXQpIHsKPj4+Pj4gKwkJaTkxNV9nZW1fY29udGV4dF9maW5pKGRldik7Cj4+Pj4+ICsJCS8q IFhYWDogYW55dGhpbmcgZWxzZSB0byBiZSB1bmRvbmUgaGVyZT8gKi8KPj4+Pgo+Pj4+IFllcy4g TWFrZSB0aGlzIGEgc2VwYXJhdGUgcGF0Y2ggYW5kIGJlZ2luIHRoZSBvbmlvbiB1bndpbmQuCj4+ Pgo+Pj4gSG1tLiBBY3R1YWxseSwgd2UgaGF2ZSB0byBtYWtlIHN1cmUgdGhhdCB3ZSBjYW4gc3Rp bGwgbW9kZXNldCBpZiB0aGlzCj4+PiBmdW5jdGlvbiBmYWlscyAtIHRoYXQgaXMgYW55dGhpbmcg YnV0IHV0dGVyIGNhdGFzdHJvcGhlIHNob3VsZCBqdXN0Cj4+PiByZXN1bHQgaW4gbG9zcyBvZiBm dW5jdGlvbmFsaXR5IChubyBzdG9sZW4sIG5vIEdFTSBleGVjdXRpb24gZXRjKSBidXQgd2UKPj4+ IGNhbiBzdGlsbCBkcml2ZSB0aGUgZGlzcGxheXMgc28gdGhlIHVzZXIgY2FuIHNlZSBob3cgYmFk IHRoZSBkYW1hZ2UgaXMuCj4+PiAtQ2hyaXMKPj4KPj4gWWVzLCBNaWthIHNhaWQgdGhhdCdzIHdo eSAoaGUgdGhvdWdodCkgdGhlcmUgd2Fzbid0IGEgY29tcGxldGUgcmV2ZXJzYWwgb2YKPj4gZXZl cnl0aGluZyB0aGUgZHJpdmVyIGhhcyBkb25lIHVwIHRvIHRoaXMgcG9pbnQuCj4+Cj4+IFRoZSBh ZGRpdGlvbiBvZiB0aGUgY29udGV4dF9maW5pKCkgc2VlbXMgcmVhc29uYWJsZSwgdGhhdCdzIGdv aW5nIHRvIG1ha2UgaXQKPj4gbGVhayBhIGJpdCBsZXNzLCB3aGlsZSBzdGlsbCBsZWF2aW5nIGJh c2ljIGZyYW1lYnVmZmVyIHdvcmtpbmcuCj4+Cj4+IENvdWxkIGJlIGEgc2VwYXJhdGUgcGF0Y2gg aWYgeW91IGxpa2UsIGJ1dCBoYXJkbHkgc2VlbXMgd29ydGggc3BsaXR0aW5nIGZyb20KPj4gdGhl IG90aGVyIGNodW5rLCB3aGljaCBhZnRlciBhbGwgb25seSByZXBsYWNlcyB1bnJlYWNoYWJsZSBj b2RlIHdpdGggYQo+PiBXQVJOaW5nLgo+Cj4gLi4uIGl0IHNob3VsZCBiZSBzcGxpdC4gQXMgYSBy dWxlIG9mIHRodW1iIGF0IGxlYXN0LiBJIGRvbid0IHJlYWxseSBjYXJlCj4gYWxsIHRoYXQgbXVj aCBoZXJlIHRob3VnaCwgc28ganV0IGZvciB0aGUgZnV0dXJlLgo+IC1EYW5pZWwKClRoYXQgd2Fz IGFscmVhZHkgZG9uZSBpbiB0aGUgdXBkYXRlZCAodjUpIHBhdGNoc2V0IHBvc3RlZCAyMDE2LTAy LTA1LgpUaGlzICh2NCkgc2VxdWVuY2UgaXMgdGhlcmVmb3JlIGFscmVhZHkgb2Jzb2xldGUuCgou RGF2ZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=