All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Tommi Airikka <tommi@airikka.net>, <linux-kernel@vger.kernel.org>,
	<xen-devel@lists.xenproject.org>, <david.vrabel@citrix.com>,
	<boris.ostrovsky@oracle.com>
Cc: <stable@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.
Date: Mon, 15 Feb 2016 14:27:14 +0000	[thread overview]
Message-ID: <56C1E042.6000200@citrix.com> (raw)
In-Reply-To: <1455225026-25792-5-git-send-email-konrad.wilk@oracle.com>

On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c

> @@ -576,6 +578,7 @@ static void pcifront_free_roots(struct pcifront_device *pdev)
>  		free_root_bus_devs(bus_entry->bus);
>  
>  		kfree(bus_entry->bus->sysdata);
> +		bus_entry->bus->sysdata = NULL;

I dropped this change, as it was unrelated.

I note that we free sysdata before removing the bus which looks racy to me.

David

  parent reply	other threads:[~2016-02-15 14:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 21:10 [PATCH] Fixes to Xen pcifront and pciback (v1) Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 1/4] xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY Konrad Rzeszutek Wilk
2016-02-12  9:19   ` [Xen-devel] " Jan Beulich
2016-02-12  9:19   ` Jan Beulich
2016-02-11 21:10 ` [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be copied later Konrad Rzeszutek Wilk
2016-02-12  9:25   ` Jan Beulich
2016-02-12  9:25   ` [Xen-devel] " Jan Beulich
2016-02-11 21:10 ` [PATCH 3/4] xen/pcifront: Report the errors better Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted Konrad Rzeszutek Wilk
2016-02-14  1:23   ` Boris Ostrovsky
2016-02-15 14:05     ` Konrad Rzeszutek Wilk
2016-02-15 14:37       ` Boris Ostrovsky
2016-02-15 14:37       ` Boris Ostrovsky
2016-02-14  1:23   ` Boris Ostrovsky
2016-02-15 14:27   ` David Vrabel [this message]
2016-02-15 14:27   ` David Vrabel
2016-02-15 14:35 ` [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel
2016-02-15 14:35 ` [Xen-devel] " David Vrabel
2016-02-15 14:38   ` David Vrabel
2016-02-15 14:38   ` [Xen-devel] " David Vrabel
2016-02-15 15:35     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C1E042.6000200@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tommi@airikka.net \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.