From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVMOa-0007Xl-Ub for qemu-devel@nongnu.org; Mon, 15 Feb 2016 11:53:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVMOV-0008QG-Uk for qemu-devel@nongnu.org; Mon, 15 Feb 2016 11:53:08 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:38479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVMOV-0008Q2-LB for qemu-devel@nongnu.org; Mon, 15 Feb 2016 11:53:03 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Feb 2016 16:53:00 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0176817D8078 for ; Mon, 15 Feb 2016 16:53:14 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1FGqueu2228562 for ; Mon, 15 Feb 2016 16:52:56 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1FGquPg032243 for ; Mon, 15 Feb 2016 09:52:56 -0700 References: <1455020010-17532-1-git-send-email-clg@fr.ibm.com> <1455020010-17532-3-git-send-email-clg@fr.ibm.com> <56C03B68.3050408@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <56C20266.2090501@fr.ibm.com> Date: Mon, 15 Feb 2016 17:52:54 +0100 MIME-Version: 1.0 In-Reply-To: <56C03B68.3050408@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/8] ipmi: use a function to initialize the SDR table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel@redhat.com, Corey Minyard Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Greg Kurz On 02/14/2016 09:31 AM, Marcel Apfelbaum wrote: > On 02/09/2016 02:13 PM, Cédric Le Goater wrote: >> This patch does not change anything. > > Hi, > > Well, it changes *something*, otherwise ... :) > > Maybe "This is only a re-factoring." Yes. This is much better. "does not change anything" doe not make sense ... C. > > > > It only moves the code section >> initializing the sdrs in its own routine and prepares ground for the >> subsequent patches. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/ipmi/ipmi_bmc_sim.c | 49 ++++++++++++++++++++++++++++--------------------- >> 1 file changed, 28 insertions(+), 21 deletions(-) >> >> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c >> index 13171336f7f1..0abc9cb5de94 100644 >> --- a/hw/ipmi/ipmi_bmc_sim.c >> +++ b/hw/ipmi/ipmi_bmc_sim.c >> @@ -1703,6 +1703,33 @@ static const uint8_t init_sdrs[] = { >> 0xff, 0xff, 0x00, 0x00, 0x00 >> }; >> >> +static void ipmi_sdr_init(IPMIBmcSim *ibs) >> +{ >> + unsigned int i; >> + unsigned int recid; >> + >> + for (i = 0;;) { > > > I am all for extracting the functionality in a function, > what bothers me a little is the above construct. > > Maybe you can find a more "standard: approach like: > > while (recid != 0xffff) { > ... > } > > Or maybe is just me. > > Thanks, > Marcel > >> + struct ipmi_sdr_header *sdrh; >> + int len; >> + if ((i + IPMI_SDR_HEADER_SIZE) > sizeof(init_sdrs)) { >> + error_report("Problem with recid 0x%4.4x", i); >> + return; >> + } >> + sdrh = (struct ipmi_sdr_header *) &init_sdrs[i]; >> + len = ipmi_sdr_length(sdrh); >> + recid = ipmi_sdr_recid(sdrh); >> + if (recid == 0xffff) { >> + break; >> + } >> + if ((i + len) > sizeof(init_sdrs)) { >> + error_report("Problem with recid 0x%4.4x", i); >> + return; >> + } >> + sdr_add_entry(ibs, sdrh, len, NULL); >> + i += len; >> + } >> +} >> + >> static const VMStateDescription vmstate_ipmi_sim = { >> .name = TYPE_IPMI_BMC_SIMULATOR, >> .version_id = 1, >> @@ -1735,7 +1762,6 @@ static void ipmi_sim_realize(DeviceState *dev, Error **errp) >> { >> IPMIBmc *b = IPMI_BMC(dev); >> unsigned int i; >> - unsigned int recid; >> IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b); >> >> qemu_mutex_init(&ibs->lock); >> @@ -1752,26 +1778,7 @@ static void ipmi_sim_realize(DeviceState *dev, Error **errp) >> ibs->sdr.last_clear[i] = 0xff; >> } >> >> - for (i = 0;;) { >> - struct ipmi_sdr_header *sdrh; >> - int len; >> - if ((i + IPMI_SDR_HEADER_SIZE) > sizeof(init_sdrs)) { >> - error_report("Problem with recid 0x%4.4x", i); >> - return; >> - } >> - sdrh = (struct ipmi_sdr_header *) &init_sdrs[i]; >> - len = ipmi_sdr_length(sdrh); >> - recid = ipmi_sdr_recid(sdrh); >> - if (recid == 0xffff) { >> - break; >> - } >> - if ((i + len) > sizeof(init_sdrs)) { >> - error_report("Problem with recid 0x%4.4x", i); >> - return; >> - } >> - sdr_add_entry(ibs, sdrh, len, NULL); >> - i += len; >> - } >> + ipmi_sdr_init(ibs); >> >> ibs->acpi_power_state[0] = 0; >> ibs->acpi_power_state[1] = 0; >> >