From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH v3 1/2] xen/x86: merge 2 hvm_event_... functions into 1 Date: Mon, 15 Feb 2016 19:40:33 +0200 Message-ID: <56C20D91.9010305@bitdefender.com> References: <1455518118-414-1-git-send-email-czuzu@bitdefender.com> <1455518118-414-2-git-send-email-czuzu@bitdefender.com> <56C18CAE.9050103@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56C18CAE.9050103@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru , xen-devel@lists.xen.org Cc: Kevin Tian , Tamas K Lengyel , Keir Fraser , Jan Beulich , Andrew Cooper , Jun Nakajima List-Id: xen-devel@lists.xenproject.org On 2/15/2016 10:30 AM, Razvan Cojocaru wrote: > On 02/15/2016 08:35 AM, Corneliu ZUZU wrote: >> This patch merges almost identical functions hvm_event_int3 and >> hvm_event_single_step into a single function called hvm_event_breakpoint. >> Also fixes event.c file header comment in the process. >> >> Signed-off-by: Corneliu ZUZU >> --- >> xen/arch/x86/hvm/event.c | 108 +++++++++++++++++++--------------------- >> xen/arch/x86/hvm/vmx/vmx.c | 15 +++--- >> xen/include/asm-x86/hvm/event.h | 11 ++-- >> 3 files changed, 67 insertions(+), 67 deletions(-) > Looks good to me. > > Acked-by: Razvan Cojocaru > > > Thanks, > Razvan > I forgot to ask: when getting an Acked-By response, should I include that patch in the next patch-series or ommit it? I've done that w/ the first patch in the last patch-series, but IDK if I was correct to do so. Thanks, Corneliu.