From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH v3 1/2] xen/x86: merge 2 hvm_event_... functions into 1 Date: Mon, 15 Feb 2016 19:54:23 +0200 Message-ID: <56C210CF.5050804@bitdefender.com> References: <1455518118-414-1-git-send-email-czuzu@bitdefender.com> <1455518118-414-2-git-send-email-czuzu@bitdefender.com> <56C18CAE.9050103@bitdefender.com> <56C20D91.9010305@bitdefender.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0384850787432820462==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: Kevin Tian , Keir Fraser , Jan Beulich , Razvan Cojocaru , Andrew Cooper , Xen-devel , Jun Nakajima List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============0384850787432820462== Content-Type: multipart/alternative; boundary="------------090907010901060709000902" This is a multi-part message in MIME format. --------------090907010901060709000902 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/15/2016 7:47 PM, Tamas K Lengyel wrote: > > > On Mon, Feb 15, 2016 at 10:40 AM, Corneliu ZUZU > wrote: > > On 2/15/2016 10:30 AM, Razvan Cojocaru wrote: > > On 02/15/2016 08:35 AM, Corneliu ZUZU wrote: > > This patch merges almost identical functions > hvm_event_int3 and > hvm_event_single_step into a single function called > hvm_event_breakpoint. > Also fixes event.c file header comment in the process. > > Signed-off-by: Corneliu ZUZU > > --- > xen/arch/x86/hvm/event.c | 108 > +++++++++++++++++++--------------------- > xen/arch/x86/hvm/vmx/vmx.c | 15 +++--- > xen/include/asm-x86/hvm/event.h | 11 ++-- > 3 files changed, 67 insertions(+), 67 deletions(-) > > Looks good to me. > > Acked-by: Razvan Cojocaru > > > > Thanks, > Razvan > > > If the patch hasn't been merged to staging yet then include it. If > it's a longer series the cover page can indicate which patches are > still in need of review and which ones have been already acked. > Furthermore, for each patch under the Signed-off-by tag you can say > what changed in each revision. If nothing changed, you can say no > change or just don't put anything for that revision. See > http://lists.xen.org/archives/html/xen-devel/2016-02/msg00943.html for > an example. Also keep in mind that if the changes in a revision are > significant enough you can't keep the Acked-by tag on the patch, it > will need to be re-acked. > > Tamas Got it, thanks. Corneliu. --------------090907010901060709000902 Content-Type: text/html; charset=utf-8 Content-Length: 4489 Content-Transfer-Encoding: quoted-printable
On 2/15/2016 7:47 PM, Tamas K Lengyel wrote:


On Mon, Feb 15, 2016 at 10:40 AM, Corneliu ZUZU <czuzu@bitdefender.com> wrote:
On 2/15/2016 10:30 AM, Razvan Cojocaru wrote:
On 02/15/2016 08:35 AM, Corneliu ZUZU wrote:
This patch merges almost identical functions hvm_event_int3 and
hvm_event_single_step into a single function called hvm_event_breakpoint.
Also fixes event.c file header comment in the process.

Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
---
=C2=A0 xen/arch/x86/hvm/event.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 108 +++++++++++++++++++---------------------
=C2=A0 xen/arch/x86/hvm/vmx/vmx.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 15 +++---
=C2=A0 xen/include/asm-x86/hvm/event.h |=C2=A0 11 ++--
=C2=A0 3 files changed, 67 insertions(+), 67 deletions(-)
Looks good to me.

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan


If the patch hasn't been merged to staging yet then include it. If it's a longer series the cover page can indicate which patches are still in need of review and which ones have been already acked. Furthermore, for each patch under the Signed-off-by tag you can say what changed in each revision. If nothing changed, you can say no change or just don't put anything for that revision. See http://lists.xen.org/archives/html/xen-devel/2016-02/msg00943.html for an example. Also keep in mind that if the changes in a revision are significant enough you can't keep the Acked-by tag on the patch, it will need to be re-acked.

Tamas

Got it, thanks.

Corneliu.
--------------090907010901060709000902-- --===============0384850787432820462== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0384850787432820462==--