From: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 23/23] nvc0: implement support for maxwell texture headers
Date: Tue, 16 Feb 2016 15:42:14 +1000 [thread overview]
Message-ID: <56C2B6B6.5090808@gmail.com> (raw)
In-Reply-To: <CAKb7UvgRddt2RbF9AJOauTtC22hkhmjR2zKApYBa8Q00Z8Z9MA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1678 bytes --]
On 02/16/2016 08:08 AM, Ilia Mirkin wrote:
> On Mon, Feb 15, 2016 at 4:40 PM, Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 02/16/2016 03:47 AM, Ilia Mirkin wrote:
>>> Can you push this to a repo somewhere? I want to see what the final
>>> version looks like after all your changes, but it's hard to see that
>>> with these patches.
>> https://github.com/skeggsb/Mesa/commits/master
>
> Thanks. I looked over this series and it seems fine. I don't hate the
> outcome in nv50_formats.c although it would have been kinda nice to
> keep it together. However outside of new compressed formats, I doubt
> it'll be getting too many updates.
>
> Perhaps tic.maxwell should really be tic.version? Presumably later
> GPUs will also use this new TIC format? [There's also a v0 that we
> don't really use but the only tic version supported by G80, which does
> the colorkey thing and doesn't support first/last level.]
>
> I would really appreciate it if you could do a piglit run comparison
> against both a nv50 and nvc0 GPU (and not maxwell - those can have
> extra-special issues). If there are no format-related regressions
> (there are a handful of flaky tests), I'm fine with this getting
> pushed.
Hey Ilia,
I've pushed an updated branch containing a small typo fix to the GM107
texture header commit, as well as an extra commit recognising GM20x
chipsets.
The piglit comparisons you requested are at:
G96:
https://drive.google.com/file/d/0B66cGbmsDhPvTUV6TTNuZHJaVGc/view?usp=sharing
GF100:
https://drive.google.com/file/d/0B66cGbmsDhPvT0hhMGU2UTRDVG8/view?usp=sharing
Thanks,
Ben.
>
> -ilia
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
prev parent reply other threads:[~2016-02-16 5:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:38 [PATCH 01/23] nv50: import updated g80_defs.xml.h from rnndb Ben Skeggs
[not found] ` <1455514736-8909-1-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-15 5:38 ` [PATCH 02/23] nv50: switch nv50_surface.c to updated g80_defs.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 03/23] nv50: switch nv50_tex.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 04/23] nv50: switch nv50_transfer.c to g80_defs.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 05/23] nv50: remove unnecessary include Ben Skeggs
2016-02-15 5:38 ` [PATCH 06/23] nvc0: switch nvc0_surface.c to updated g80_defs.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 07/23] nvc0: switch nvc0_tex.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 08/23] nvc0: remove unnecessary includes Ben Skeggs
2016-02-15 5:38 ` [PATCH 09/23] nv50-: separate vertex formats from surface format descriptions Ben Skeggs
[not found] ` <1455514736-8909-9-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-15 5:43 ` Ilia Mirkin
[not found] ` <CAKb7Uvg=rL_GLTRU+u_rvWZOmE8C1HiuonmgdvEKxV9ZzSyQ6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-15 5:49 ` Ben Skeggs
2016-02-15 5:38 ` [PATCH 10/23] nv50-: improved macros to handle format specification Ben Skeggs
2016-02-15 5:38 ` [PATCH 11/23] nv50-: switch nv50_formats.c to updated g80_defs.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 12/23] nv50-: remove nv50_defs.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 13/23] nv50: import updated g80_texture.xml.h from rnndb Ben Skeggs
2016-02-15 5:38 ` [PATCH 14/23] nv50-: switch nv50_formats.c to updated g80_texture.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 15/23] nv50: switch nv50_state.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 16/23] nv50: switch nv50_surface.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 17/23] nv50: switch nv50_tex.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 18/23] nvc0: switch nvc0_surface.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 19/23] nvc0: switch nvc0_tex.c " Ben Skeggs
2016-02-15 5:38 ` [PATCH 20/23] nv50-: remove nv50_texture.xml.h Ben Skeggs
2016-02-15 5:38 ` [PATCH 21/23] nv50-: split tic format specification Ben Skeggs
2016-02-15 5:38 ` [PATCH 22/23] nvc0: import maxwell texture header definitions from rnndb Ben Skeggs
2016-02-15 5:38 ` [PATCH 23/23] nvc0: implement support for maxwell texture headers Ben Skeggs
[not found] ` <1455514736-8909-23-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-15 17:47 ` Ilia Mirkin
[not found] ` <CAKb7UvgjAjgyvMUS31fS8Jq+vqsO_XyeVreuFsaioU1etoQ_pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-15 21:40 ` Ben Skeggs
[not found] ` <56C245BF.50908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-15 22:08 ` Ilia Mirkin
[not found] ` <CAKb7UvgRddt2RbF9AJOauTtC22hkhmjR2zKApYBa8Q00Z8Z9MA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-16 5:42 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C2B6B6.5090808@gmail.com \
--to=skeggsb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.