From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 0/3] drm: more pre-decrement fixes Date: Tue, 16 Feb 2016 09:21:23 +0100 Message-ID: <56C2DC03.7000207@vodafone.de> References: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id C95F06E752 for ; Tue, 16 Feb 2016 08:21:28 +0000 (UTC) In-Reply-To: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rasmus Villemoes , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org QW0gMTUuMDIuMjAxNiB1bSAxOTo0MSBzY2hyaWViIFJhc211cyBWaWxsZW1vZXM6Cj4gQSBmZXcg bW9yZSBjYXNlcyB3aGVyZSBvbmUgc2hvdWxkIHVzZSBwb3N0LWRlY3JlbWVudCB3aGVuIHVud2lu ZGluZywKPiB0aGlzIHRpbWUgZm91bmQgd2hlcmUgdGhlIHVud2luZGluZyBpcyBkb25lIGluc2lk ZSB0aGUgc2V0dXAgbG9vcAo+IGluc3RlYWQgb2YgYWZ0ZXIgYW4gZXJyb3IgbGFiZWwuCgpQYXRj aCAxIGFuZCAzIGFyZSBSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtv ZW5pZ0BhbWQuY29tPi4KCk5pY2UgY2F0Y2gsCkNocmlzdGlhbi4KCj4KPiBSYXNtdXMgVmlsbGVt b2VzICgzKToKPiAgICBkcm0vYW1kZ3B1OiB1c2UgcG9zdC1kZWNyZW1lbnQgaW4gZXJyb3IgaGFu ZGxpbmcKPiAgICBkcm0vbm91dmVhdTogdXNlIHBvc3QtZGVjcmVtZW50IGluIGVycm9yIGhhbmRs aW5nCj4gICAgZHJtL3JhZGVvbjogdXNlIHBvc3QtZGVjcmVtZW50IGluIGVycm9yIGhhbmRsaW5n Cj4KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyB8IDIgKy0KPiAg IGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfYm8uYyAgICB8IDIgKy0KPiAgIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0bS5jICAgICB8IDIgKy0KPiAgIDMgZmlsZXMgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbcBPI3o (ORCPT ); Tue, 16 Feb 2016 03:29:44 -0500 Received: from pegasos-out.vodafone.de ([80.84.1.38]:34930 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbcBPI3m (ORCPT ); Tue, 16 Feb 2016 03:29:42 -0500 X-Greylist: delayed 493 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Feb 2016 03:29:42 EST X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 781F95A3FA2 Subject: Re: [PATCH 0/3] drm: more pre-decrement fixes To: Rasmus Villemoes , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <56C2DC03.7000207@vodafone.de> Date: Tue, 16 Feb 2016 09:21:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.02.2016 um 19:41 schrieb Rasmus Villemoes: > A few more cases where one should use post-decrement when unwinding, > this time found where the unwinding is done inside the setup loop > instead of after an error label. Patch 1 and 3 are Reviewed-by: Christian König . Nice catch, Christian. > > Rasmus Villemoes (3): > drm/amdgpu: use post-decrement in error handling > drm/nouveau: use post-decrement in error handling > drm/radeon: use post-decrement in error handling > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >