From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 1/7] device: prevent a NULL pointer dereference in __intel_peek_fd Date: Tue, 16 Feb 2016 08:54:02 +0000 Message-ID: <56C2E3AA.5080203@intel.com> References: <1455294689-29249-1-git-send-email-martin.peres@linux.intel.com> <1455294689-29249-2-git-send-email-martin.peres@linux.intel.com> <56C1C364.8050602@intel.com> <56C1D55A.7040707@linux.intel.com> <56C1D70B.3040204@intel.com> <56C1F512.6000606@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F1836E769 for ; Tue, 16 Feb 2016 08:54:04 +0000 (UTC) In-Reply-To: <56C1F512.6000606@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Martin Peres , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTUvMDIvMTYgMTU6NTYsIE1hcnRpbiBQZXJlcyB3cm90ZToKPiBPbiAxNS8wMi8xNiAxNTo0 NywgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IE9uIDE1LzAyLzE2IDEzOjQwLCBNYXJ0aW4gUGVyZXMg d3JvdGU6Cj4+PiBPbiAxNS8wMi8xNiAxNDoyNCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+Pj4gT24g MTIvMDIvMTYgMTY6MzEsIE1hcnRpbiBQZXJlcyB3cm90ZToKPj4+Pj4gVGhpcyBpcyBub3QgYSBi aWcgaXNzdWUgdG8gcmV0dXJuIC0xIHNpbmNlIHRoZSBvbmx5IGNvZGVwYXRoIHRoYXQgdXNlcwo+ Pj4+PiBpdCBpcyBmb3IgZGlzcGxheSBwdXJwb3Nlcy4KPj4+Pj4KPj4+Pj4gQ2F1Z2h0IGJ5IEts b2Nrd29yay4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFydGluIFBlcmVzIDxtYXJ0aW4u cGVyZXNAbGludXguaW50ZWwuY29tPgo+Pj4+PiAtLS0KPj4+Pj4gICBzcmMvaW50ZWxfZGV2aWNl LmMgfCA1ICsrKystCj4+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvc3JjL2ludGVsX2RldmljZS5jIGIv c3JjL2ludGVsX2RldmljZS5jCj4+Pj4+IGluZGV4IDU0YzE0NDMuLjM1ZTY1MmEgMTAwNjQ0Cj4+ Pj4+IC0tLSBhL3NyYy9pbnRlbF9kZXZpY2UuYwo+Pj4+PiArKysgYi9zcmMvaW50ZWxfZGV2aWNl LmMKPj4+Pj4gQEAgLTY1MCw3ICs2NTAsMTAgQEAgaW50IF9faW50ZWxfcGVla19mZChTY3JuSW5m b1B0ciBzY3JuKQo+Pj4+PiAgICAgICBkZXYgPSBpbnRlbF9kZXZpY2Uoc2Nybik7Cj4+Pj4+ICAg ICAgIGFzc2VydChkZXYgJiYgZGV2LT5mZCAhPSAtMSk7Cj4+Pj4KPj4+PiBEb2Vzbid0IEtsb2N3 b3JrIHJlY29nbmlzZSB0aGUgYXNzZXJ0KCkgYWJvdmU/Cj4+Pj4gSSB0aG91Z2h0IHRoYXQgd291 bGQgdGVsbCBpdCB0aGF0IGRldiBjYW4ndCBiZSBOVUxMLgo+Pj4KPj4+IEl0IGRvZXMgbm90LCBJ IGhhZCB0byBjbG9zZSBtYW55IGZhbHNlIHBvc2l0aXZlcyByZWxhdGVkIHRvIHRoaXMuLi4KPj4K Pj4gSG1tbSAuLiBlbHNld2hlcmUgKGUuZy4gWzQvN10pIHlvdSBoYXZlIC9hZGRlZC8gYW4gYXNz ZXJ0LCB3aGljaCBJCj4+IHRob3VnaHQgbXVzdCBiZSBzbyB0aGF0IEtsb2N3b3JrIHN0b3BzIGNv bXBsYWluaW5nIHRoYXQgc29tZXRoaW5nIG1pZ2h0Cj4+IGJlIE5VTEwgLi4uIG1heWJlIGl0IGNh bid0IGhhbmRsZSB0aGUgY29tcG9zaXRlIGFzc2VydGlvbj8gRG9lcyBpdAo+PiBzaWxlbmNlIHRo ZSBjb21wbGFpbnQgaWYgeW91IGNoYW5nZToKPj4gICAgICBhc3NlcnQoZGV2ICYmIGRldi0+ZmQg IT0gLTEpOwo+PiBpbnRvOgo+PiAgICAgIGFzc2VydChkZXYpOwo+PiAgICAgIGFzc2VydChkZXYt PmZkICE9IC0xKTsKPj4gPwo+Cj4gU3VyZSwgSSBhZGRlZCBhbiBhc3NlcnQsIGJ1dCBub3QgdG8g c2lsZW5jZSBwYXRjaHdvcmssIGp1c3QgdG8gbWFrZSBzdXJlCj4gd2UgaGF2ZSBubyBwcm9ibGVt LiBJIGNhbm5vdCBydW4ga2xva3dvcmsgbXlzZWxmIGFuZCBteSBnb2FsIHdhcyBub3QgdG8KPiBz aWxlbmNlIGJ1dCBpbnN0ZWFkIHRvIGNoZWNrIHRoZSByZXBvcnRlZCBpc3N1ZXMuCj4KPiBEYXZp ZCBpcyByaWdodCwgSSB0aGluayBLbG9rd29yayBvbmx5IGNhcmVzIGFib3V0IHJ1bnRpbWUgY2hl Y2tzIGFuZAo+IHdhbnRzIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIG5ldmVyIGRlLXJlZmVyZW5jZSBh IE5VTEwgcG9pbnRlci4KPgo+IE1hcnRpbgoKS2xvY3dvcmsgaXMgdHJ5aW5nIChieSBzdGF0aWMg YW5hbHlzaXMpIHRvIGZpbmQgYWxsIHJlYWNoYWJsZSBjb2RlLCB3aXRoIAphbGwgcG9zc2libGUg cGFyYW1ldGVyIHZhbHVlcyBhdCBlYWNoIHBvaW50LiBJdCdzIGNvbmZpZ3VyZWQgd2l0aCAKdmFy aW91cyBjaGVja2VycyB0aGF0IGV4YW1pbmUgZWFjaCBleHByZXNzaW9uIHJlYWNoZWQgZm9yIHRo aW5ncyBzdWNoIGFzIApkZXJlZmVyZW5jaW5nIGEgcG9zc2libHktTlVMTCBwb2ludGVyLCBvciBp bmRleGluZyBiZXlvbmQgdGhlIGJvdW5kcyBvZiAKYW4gYXJyYXksIG9yIGludGVnZXIgb3ZlcmZs b3csIG9yIG1hbnkgb3RoZXIgdGhpbmdzIC4uLgoKVGhlIHN0YW5kYXJkIGRlZmluaXRpb24gb2Yg YXNzZXJ0KCkgaXMgc29tZXRoaW5nIGxpa2U6CgogICAgICNkZWZpbmUgYXNzZXJ0KHgpIGRvIHsg aWYoISh4KSkgYWJvcnQoKTsgfSB3aGlsZSAoMCkKCmFuZCBLbG9jd29yayBrbm93cyB0aGF0IGFi b3J0KCkgZG9lc24ndCByZXR1cm4sIHNvIGluIHRoZSBibG9jawoKICAgICBkZXYgPSBpbnRlbF9k ZXZpY2Uoc2Nybik7CiAgICAgYXNzZXJ0KGRldik7CiAgICAgcmV0dXJuIGRldi0+ZmQ7CgppdCBj YW4gZGVkdWNlIHRoYXQgdGhlICdyZXR1cm4nIGlzIHJlYWNoZWQgb25seSBpZiB0aGUgYWJvcnQo KSB3YXMgbm90LCAKaGVuY2Ugb25seSBpZiAnZGV2JyBpcyBub24tTlVMTC4gVGhlcmVmb3JlLCB0 aGlzIGRvZXNuJ3QgcHJvZHVjZSBhIApjb21wbGFpbnQgYWJvdXQgYSBwb3NzaWJseS1OVUxMIHBv aW50ZXIsIGJlY2F1c2UgS2xvY3dvcmsga25vd3MgaXQgaXNuJ3QgCmJlY2F1c2Ugb2YgdGhlIGFz c2VydCgpLgoKT2YgY291cnNlIHRoZXJlIGFyZSBwb3RlbnRpYWxseSBtdWx0aXBsZSBkZWZpbml0 aW9ucyBvZiBhc3NlcnQoKSwgCnR5cGljYWxseSBpbmNsdWRpbmcgYSBudWxsIG9uZSwgZm9yIHBy b2R1Y3Rpb24gY29kZSwgYW5kIGEgZGVidWcgdmVyc2lvbiAKdGhhdCBnaXZlcyBtb3JlIGRldGFp bC4gU28gdGhlIHVzdWFsIHRoaW5nIGlzIHRvIGVuc3VyZSB0aGF0IHRoZXJlJ3MgYSAKS2xvY3dv cmstc3BlY2lmaWMgdmVyc2lvbiB0aGF0IGFsbG93cyBLVyB0byBkbyB0aGUgYW5hbHlzaXMgYWJv dmUsIGV2ZW4gCmlmIHRoYXQgdmVyc2lvbiBpc24ndCBzb21ldGhpbmcgeW91IHdvdWxkIGV2ZXIg cnVuOgoKI2lmICAgIGRlZmluZWQoX19LTE9DV09SS19fKQojZGVmaW5lIGFzc2VydCh4KSBkbyB7 IGlmKCEoeCkpIGFib3J0KCk7IH0gd2hpbGUgKDApCiNlbGlmICBkZWZpbmVkKE5PX0RFQlVHKQoj ZGVmaW5lIGFzc2VydCh4KSBkbyB7IC8qIG5vdGhpbmcgKi8gOyB9IHdoaWxlICgwKQojZWxpZiAg ZGVmaW5lZChFWFRSQV9ERUJVRykKI2RlZmluZSBhc3NlcnQoeCkgZG8geyBteV9hc3NlcnQoeCwg I3gsIF9fTElORV9fLCBfX0ZJTEVfXyk7IH0gd2hpbGUgKDApCiNlbHNlCi8vIC4uLiBldGMgLi4u CiNlbmRpZgoKSWYgd2UgZG9uJ3QgaGF2ZSBzb21ldGhpbmcgbGlrZSB0aGlzLCBLbG9jd29yayBt YXkgbm90IGJlIGFibGUgdG8gbWFrZSAKZWZmZWN0aXZlIGRlZHVjdGlvbnMgYWJvdXQgdGhlIHBv c3NpYmxlIHZhbHVlcyBvZiB2YXJpYWJsZXMgYXQgc3BlY2lmaWMgCnBvaW50cywgc28gaXQgd291 bGQgYmUgd29ydGggY2hlY2tpbmcgdGhhdCB3ZSdyZSB1c2luZyBtYWNyb3MgdGhhdCBpdCAKdW5k ZXJzdGFuZHMuCgouRGF2ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==