All of lore.kernel.org
 help / color / mirror / Atom feed
From: Remy Horton <remy.horton@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	pablo.de.lara.guarch@intel.com, declan.doherty@intel.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/3] eal: fix keep alive header for C++
Date: Tue, 16 Feb 2016 10:16:35 +0000	[thread overview]
Message-ID: <56C2F703.2020801@intel.com> (raw)
In-Reply-To: <1455606865-22680-2-git-send-email-thomas.monjalon@6wind.com>


Suspect this will introduce an extra indirection and call/return into 
the generated code, but can't think of any alternative that doesn't 
potentially break source compatibility..


On 16/02/2016 07:14, Thomas Monjalon wrote:
> When built in a C++ application, the keepalive include fails:
>
> rte_keepalive.h:142:41: error: ‘ALIVE’ was not declared in this scope
>    keepcfg->state_flags[rte_lcore_id()] = ALIVE;
>                                           ^
> C++ requires to use a scope operator to access an enum inside a struct.
> There was also a namespace issue for the values (no RTE prefix).
> The solution is to move the struct and related code out of the header file.
>
> Fixes: 75583b0d1efd ("eal: add keep alive monitoring")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Remy Horton <remy.horton@intel.com>

  reply	other threads:[~2016-02-16 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 17:06 [PATCH 0/3] fix C++ includes Thomas Monjalon
2016-02-05 17:06 ` [PATCH 1/3] eal: fix keep alive header for C++ Thomas Monjalon
2016-02-15 11:16   ` Remy Horton
2016-02-05 17:06 ` [PATCH 2/3] hash: fix " Thomas Monjalon
2016-02-08 13:42   ` De Lara Guarch, Pablo
2016-02-05 17:06 ` [PATCH 3/3] mbuf_offload: " Thomas Monjalon
2016-02-05 21:33   ` Thomas Monjalon
2016-02-16  7:14 ` [PATCH v2 0/3] fix C++ includes Thomas Monjalon
2016-02-16  7:14   ` [PATCH v2 1/3] eal: fix keep alive header for C++ Thomas Monjalon
2016-02-16 10:16     ` Remy Horton [this message]
2016-02-16  7:14   ` [PATCH v2 2/3] hash: fix " Thomas Monjalon
2016-02-16  7:14   ` [PATCH v2 3/3] mbuf_offload: " Thomas Monjalon
2016-02-16 16:21   ` [PATCH v2 0/3] fix C++ includes Ferruh Yigit
2016-02-16 16:26     ` Thomas Monjalon
2016-02-16 18:33       ` Marc
2016-02-21 10:49   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C2F703.2020801@intel.com \
    --to=remy.horton@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.