Re: [PATCH v4 8/8] drm/i915: Remove vblank wait from hsw_enable_ips.

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Hey,

Op 12-02-16 om 13:06 schreef Zanoni, Paulo R:
> Em Qua, 2016-02-10 às 13:49 +0100, Maarten Lankhorst escreveu:
>> intel_post_plane_update did an extra vblank wait that's no longer
>> needed when enabling ips.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 6bb1f5dbc7a0..19a8d376d63e 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -4569,9 +4569,6 @@ void hsw_enable_ips(struct intel_crtc *crtc)
>>  	if (!crtc->config->ips_enabled)
>>  		return;
>>  
>> -	/* We can only enable IPS after we enable a plane and wait
>> for a vblank */
> Perhaps we can keep the comment, but change it into something like:
>
> /* We can only enable IPS after we enable a plane and wait for a
> vblank, but we don't need the wait here because of XYZ. */
>
post_plane_update only gets run after a vblank wait now, so I think adding a comment here is optional.
But yeah I'll make it more clear in the commit.

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx