From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms@verge.net.au>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: ravb: Possible Regression In "net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS"
Date: Tue, 16 Feb 2016 14:06:55 +0300 [thread overview]
Message-ID: <56C302CF.2030300@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdXvnY0i69jSfxk_2K0Ac0PtjF7G7QMXKOh6KOLQE8MsMg@mail.gmail.com>
Hello.
On 2/16/2016 10:42 AM, Geert Uytterhoeven wrote:
>> I have observed what appears to be a regression in the ravb ethernet driver
>> caused by d5c3d84657db ("net: phy: Avoid polling PHY with
>> PHY_IGNORE_INTERRUPTS").
>>
>> When booting net-next configured with the ARM64 defconfig on the Renesas
>> r8a7795/salvator-x I see the following and the ravb is unable to access the
>> network. With the above mentioned patch reverted I am able to boot to
>> user-space using nfsroot.
>
> The ravb interrupt is connected to a GPIO controller, which is
> runtime-suspended and thus not serving the interrupt.
>
> Cfr. "[PATCH/RFC] gpio: rcar: Add Runtime PM handling for interrupts"
> (http://www.spinics.net/lists/linux-renesas-soc/msg00532.html).
>
> I assume it worked before as the PHY driver polled the PHY instead of relying
> solely on the interrupt.
Correct. BTW, I'm going to look at handling AVB_PHY_INT in the ravb
driver, thus removing the need for routing it to the GPIO controller now that
phylib allows this again...
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
next prev parent reply other threads:[~2016-02-16 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 3:26 ravb: Possible Regression In "net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS" Simon Horman
2016-02-16 5:08 ` Florian Fainelli
2016-02-16 5:08 ` Florian Fainelli
2016-02-16 5:12 ` Simon Horman
2016-02-16 7:42 ` Geert Uytterhoeven
2016-02-16 11:06 ` Sergei Shtylyov [this message]
2016-02-17 6:35 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C302CF.2030300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.