From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1aVfq2-00064O-Mr
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 08:38:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1aVfq2-0000wj-0N
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 08:38:46 -0500
References: <1455318392-26765-1-git-send-email-jsnow@redhat.com>
	<1455318392-26765-2-git-send-email-jsnow@redhat.com>
	<20160214064613.GA31933@ad.usersys.redhat.com>
From: John Snow <jsnow@redhat.com>
Message-ID: <56C32660.6080703@redhat.com>
Date: Tue, 16 Feb 2016 08:38:40 -0500
MIME-Version: 1.0
In-Reply-To: <20160214064613.GA31933@ad.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size
	configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org



On 02/14/2016 01:46 AM, Fam Zheng wrote:
> On Fri, 02/12 18:06, John Snow wrote:
>>  typedef struct CowRequest {
>> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
>>      CoRwlock flush_rwlock;
>>      uint64_t sectors_read;
>>      HBitmap *bitmap;
>> +    int64_t cluster_size;
>> +    int64_t sectors_per_cluster;
> 
> I don't think it makes sense to duplicate one value in two units.
> 
> Fam
> 

Eh, fair.

I just didn't want to duplicate the math everywhere. I can add a little
macro or an inline function instead.

--js