From: Daniel Borkmann <daniel@iogearbox.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: meta: add PRANDOM support
Date: Tue, 16 Feb 2016 14:56:23 +0100 [thread overview]
Message-ID: <56C32A87.2000104@iogearbox.net> (raw)
In-Reply-To: <20160216131910.GC13417@breakpoint.cc>
On 02/16/2016 02:19 PM, Florian Westphal wrote:
> Daniel Borkmann <daniel@iogearbox.net> wrote:
>>> + case NFT_META_PRANDOM:
>>> + if (!prand_inited) {
>>> + prandom_seed_full_state(&nft_prandom_state);
>>> + prand_inited = true;
>>> + }
>>
>> Should this be: prandom_init_once() ?
>
> Thought about that but this is slowpath so I considered
> the use of static key magic a bit overkill....
>
> I don't mind, if you think prandom_init_once is prefereable I'll respin.
You'd have the benefit that the prng init would be race free. nft_meta_get_init()
could be called in parallel from multiple CPUs, right?
> Let me know, thanks!
next prev parent reply other threads:[~2016-02-16 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 12:09 [PATCH nf-next] netfilter: meta: add PRANDOM support Florian Westphal
2016-02-16 12:48 ` Daniel Borkmann
2016-02-16 13:19 ` Florian Westphal
2016-02-16 13:56 ` Daniel Borkmann [this message]
2016-02-16 14:09 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C32A87.2000104@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.