Re: [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.

[Carlos Palminha <CARLOS.PALMINHA@synopsys.com>]

Thanks!

On 16-02-2016 14:37, Daniel Vetter wrote:
> On Tue, Feb 16, 2016 at 02:10:03PM +0000, Carlos Palminha wrote:
>> This patch set nukes all the dummy crtc mode_fixup implementations.
>> (made on top of Daniel topic/drm-misc branch)
>>
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> 
> Applied this one to drm-misc. I'll let the others hang out there for a bit
> more to collect acks.
> 
> Thanks, Daniel
> 
>> ---
>>  drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
>> index e70d064..7539eea 100644
>> --- a/drivers/gpu/drm/drm_crtc_helper.c
>> +++ b/drivers/gpu/drm/drm_crtc_helper.c
>> @@ -343,9 +343,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
>>  		}
>>  	}
>>  
>> -	if (!(ret = crtc_funcs->mode_fixup(crtc, mode, adjusted_mode))) {
>> -		DRM_DEBUG_KMS("CRTC fixup failed\n");
>> -		goto done;
>> +	if (crtc_funcs->mode_fixup) {
>> +		if (!(ret = crtc_funcs->mode_fixup(crtc, mode,
>> +						adjusted_mode))) {
>> +			DRM_DEBUG_KMS("CRTC fixup failed\n");
>> +			goto done;
>> +		}
>>  	}
>>  	DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
>>  
>> -- 
>> 2.5.0
>>
>