From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Date: Tue, 16 Feb 2016 16:01:00 +0000 Subject: Re: [PATCH resend] video: Use bool instead int pointer for get_opt_bool() argument Message-Id: <56C347BC.7000005@bmw-carit.de> List-Id: References: <1455009512-26806-1-git-send-email-daniel.wagner@bmw-carit.de> <56C320B8.1070900@ti.com> In-Reply-To: <56C320B8.1070900@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Tomi Valkeinen , Maik Broemme Cc: Jean-Christophe Plagniol-Villard , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 02/16/2016 02:14 PM, Tomi Valkeinen wrote: > > On 09/02/16 11:18, Daniel Wagner wrote: >> As the function name already indicates that get_opt_bool() parses >> for a bool. It is not a surprise that compiler is complaining >> about it when -Werror=incompatible-pointer-types is used: >> >> drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’: >> drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types] >> if (get_opt_bool(this_opt, "accel", &accel)) >> >> Signed-off-by: Daniel Wagner >> Reported-by: Fengguang Wu >> --- >> [resend because Maik's emial address bounced last try] >> >> Hi, >> >> In the 'simple wait queue support' series is a patch >> which turns on -Werror=incompatible-pointer-types which will >> result in a compile error for intelfb. >> >> https://lkml.org/lkml/2016/1/28/462 >> >> Even if that patch wont make it, this one makes sense (at least >> for me :)) >> >> I'll prepend this patch to the next version of the series in order >> to see if I got rid of all incompatible pointer types errors caught >> by the kbuild test robot. > > The patch looks good to me, but I didn't quite catch the above. So do > you want me to apply this to fbdev tree, or do you need to take this via > some other tree? If the latter, you have my ack. I don't have any preference on the routing. So if you take it via fbdev that would be nice. One thing less to care about :) thanks, daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964786AbcBPQBM (ORCPT ); Tue, 16 Feb 2016 11:01:12 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:56626 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933022AbcBPQBG (ORCPT ); Tue, 16 Feb 2016 11:01:06 -0500 X-CTCH-RefID: str=0001.0A0C0204.56C347BD.02E3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: [PATCH resend] video: Use bool instead int pointer for get_opt_bool() argument To: Tomi Valkeinen , Maik Broemme References: <1455009512-26806-1-git-send-email-daniel.wagner@bmw-carit.de> <56C320B8.1070900@ti.com> CC: Jean-Christophe Plagniol-Villard , , From: Daniel Wagner Message-ID: <56C347BC.7000005@bmw-carit.de> Date: Tue, 16 Feb 2016 17:01:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56C320B8.1070900@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2016 02:14 PM, Tomi Valkeinen wrote: > > On 09/02/16 11:18, Daniel Wagner wrote: >> As the function name already indicates that get_opt_bool() parses >> for a bool. It is not a surprise that compiler is complaining >> about it when -Werror=incompatible-pointer-types is used: >> >> drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’: >> drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types] >> if (get_opt_bool(this_opt, "accel", &accel)) >> >> Signed-off-by: Daniel Wagner >> Reported-by: Fengguang Wu >> --- >> [resend because Maik's emial address bounced last try] >> >> Hi, >> >> In the 'simple wait queue support' series is a patch >> which turns on -Werror=incompatible-pointer-types which will >> result in a compile error for intelfb. >> >> https://lkml.org/lkml/2016/1/28/462 >> >> Even if that patch wont make it, this one makes sense (at least >> for me :)) >> >> I'll prepend this patch to the next version of the series in order >> to see if I got rid of all incompatible pointer types errors caught >> by the kbuild test robot. > > The patch looks good to me, but I didn't quite catch the above. So do > you want me to apply this to fbdev tree, or do you need to take this via > some other tree? If the latter, you have my ack. I don't have any preference on the routing. So if you take it via fbdev that would be nice. One thing less to care about :) thanks, daniel