From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aViGo-0003QY-V5 for mharc-grub-devel@gnu.org; Tue, 16 Feb 2016 11:14:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aViGn-0003QN-05 for grub-devel@gnu.org; Tue, 16 Feb 2016 11:14:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aViGj-0001gH-Q8 for grub-devel@gnu.org; Tue, 16 Feb 2016 11:14:32 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:9792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aViGj-0001fn-KU for grub-devel@gnu.org; Tue, 16 Feb 2016 11:14:29 -0500 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id u1GG7NXs010988; Tue, 16 Feb 2016 08:14:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=NEKVhz5GC3x0YuudDzCw7Zh2mEUMDKQUv1S9pTYpKCg=; b=p1Jx8bMFDxtBupT/Q80w4iw5cPJtq/AXLNnAdV1FjydV6xNH3ChIXainJziM6O09tGg1 eehOrrUrVQHb5Nhqzij/Mqisc71X8NVE+G+EoSYUvA+1wocidRVLuKxuEsMxKUgOH114 KKRST+5YlVWZImZNv5Y+5qA3ObgvQXpfSpI= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 21216btb3u-12 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 16 Feb 2016 08:14:25 -0800 Received: from localhost.localdomain (192.168.54.13) by mail.thefacebook.com (192.168.16.16) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 16 Feb 2016 08:13:21 -0800 Subject: Re: [PATCH 05/14] net: don't free uninitialized sockets in dns To: Andrei Borzenkov , The development of GNU GRUB , References: <1455139268-3241273-1-git-send-email-jbacik@fb.com> <1455139268-3241273-6-git-send-email-jbacik@fb.com> <56BF6F19.8030609@gmail.com> From: Josef Bacik Message-ID: <56C34A9F.3010005@fb.com> Date: Tue, 16 Feb 2016 11:13:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56BF6F19.8030609@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-02-16_08:, , signatures=0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-00082601.pphosted.com id u1GG7NXs010988 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.153.30 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 16:14:34 -0000 On 02/13/2016 12:59 PM, Andrei Borzenkov wrote: > 11.02.2016 00:20, Josef Bacik =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> If we cannot open a connection to our dns server we will have NULL soc= kets in >> our array, so don't do the cleanup on any sockets that didn't get crea= ted. >> > > Was not it already fixed by > Yes it was, sorry about that, I rebased without thinking. I'll drop=20 this one. Josef