From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tirumalesh Chalamarla Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 Date: Tue, 16 Feb 2016 11:14:44 -0800 Message-ID: <56C37524.5090000@caviumnetworks.com> References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0078.outbound.protection.outlook.com ([207.46.100.78]:7424 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753850AbcBPTOu (ORCPT ); Tue, 16 Feb 2016 14:14:50 -0500 In-Reply-To: <20160216144250.GD31343@rric.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Robert Richter , Tejun Heo Cc: stripathi@apm.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 02/16/2016 06:42 AM, Robert Richter wrote: > On 15.02.16 13:30:41, Tejun Heo wrote: >> On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: >>> There is no need for special Driver, AHCI is sufficient for ThunderX, the >>> file only contains this interrupt handler, >>> is it preferable if this interrupt handler in libahci.c with others, instead >>> of separate file? >> >> Yeap, just fold it in ahci.c with surrounding #ifdef guard. > > Yes, please use #ifdef CONFIG_CAVIUM_ERRATUM_22536 ... and add a > kconfig entry for this to arch/arm64/Kconfig. > Are you sure, this is not a workaround that is based on alternative framework rather on pci device and vendor do you think CONFIG_ARCH_THUNDER a good alternative? > -Robert > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tchalamarla@caviumnetworks.com (Tirumalesh Chalamarla) Date: Tue, 16 Feb 2016 11:14:44 -0800 Subject: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 In-Reply-To: <20160216144250.GD31343@rric.localdomain> References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> Message-ID: <56C37524.5090000@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/16/2016 06:42 AM, Robert Richter wrote: > On 15.02.16 13:30:41, Tejun Heo wrote: >> On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: >>> There is no need for special Driver, AHCI is sufficient for ThunderX, the >>> file only contains this interrupt handler, >>> is it preferable if this interrupt handler in libahci.c with others, instead >>> of separate file? >> >> Yeap, just fold it in ahci.c with surrounding #ifdef guard. > > Yes, please use #ifdef CONFIG_CAVIUM_ERRATUM_22536 ... and add a > kconfig entry for this to arch/arm64/Kconfig. > Are you sure, this is not a workaround that is based on alternative framework rather on pci device and vendor do you think CONFIG_ARCH_THUNDER a good alternative? > -Robert > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbcBPTac (ORCPT ); Tue, 16 Feb 2016 14:30:32 -0500 Received: from mail-bn1bon0092.outbound.protection.outlook.com ([157.56.111.92]:30302 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755524AbcBPTab (ORCPT ); Tue, 16 Feb 2016 14:30:31 -0500 X-Greylist: delayed 143646 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Feb 2016 14:30:31 EST Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=caviumnetworks.com; Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 To: Robert Richter , Tejun Heo References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> CC: , , , From: Tirumalesh Chalamarla Message-ID: <56C37524.5090000@caviumnetworks.com> Date: Tue, 16 Feb 2016 11:14:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160216144250.GD31343@rric.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BY2PR1001CA0052.namprd10.prod.outlook.com (25.164.163.20) To SN1PR0701MB1790.namprd07.prod.outlook.com (25.162.100.144) X-Microsoft-Exchange-Diagnostics: 1;SN1PR0701MB1790;2:/HYp1fuLTskd4cVJkbhD97RgeDalGoB9DgTnAuTwHmB2gNOpcdQizkvC3De7l5XAJLvzD44DNNWE4sdYo5SohuxjjN+sifkmvolVDWVNojqhzoLAS4AnxSOp6wfoyC5OcmoEiw66XvHbwdseSe87ww==;3:xFxszV2B1riJ5VqtJSt3NpllYiGJ93Ddr+StnZZPrhxZfBvNg/FpKHUhbiBqUKWujYy7q2tS0jKOnKRWc9ssR2nTPE80uFf3V+1G6Ep7dq/aqqyadd+t181NZ6qUylk8;25:lRVy1U/In8GFs0GBkP3MxhUndim1ialnCOjkI0aQOiaWHMoAeg+jfY9iPQPvDbbfyKfaCwHEccP/Si86dWQo/reHWAn3qmjI4V6+sQYuBO1EXZlYpSAe1c+DViX7cFpiiHcXuSFjGnV3c6lh2qVPQUOgXrZ5EGEGEoyGi+P2o6nXtavHMfpR0bP1GcwutOgth1i/acPmryHWeU6SWqXEHQ5ZDatoR9DRN5N3Pfno9aEoTvHeyTttghBXWH04PFcgGjuyCoVghBJOQylChhV0WQQzzf5k8iK0Le5+sapWj5wrIMolWk39vis5Xo7frjuL X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0701MB1790; X-MS-Office365-Filtering-Correlation-Id: 80be386d-c0b1-400b-5531-08d33705704c X-Microsoft-Exchange-Diagnostics: 1;SN1PR0701MB1790;20:5Y15M9iOKk6p2Y+VK73Pzh2ij2fK36CvNQMNfUHKKI2UulqJQ5ZZ1zaoLC08uYWTljc8tqqzUTRloshuE+8fmzsESiEnoPdDLFZQgWAvZ9lPpriCN8HSKzExz1j6jKATW0dHIrhUrF1sIxHGxQPaePmIqPtM86Wd+yEBLEqZOCOrSgbUfF1lX5o7ImiFtMv48czl/Tp7nF8qrKXnXXtGXpC44ewKahp8SOYGGUAMPK1SHWD4IczINCHQHE1qv82czfgS3t/xkomjiSYR4feyqDUpOoZbx74G6a/Pl/C1wPQgIrwBYJqnJiV/Gwe+5Ul0Z2DFf6T6dbvzch4LgECgs0TD3RpFSp+6p6YwQzuR+fNghHMfaWnl/dtIOoDuCjmphQhGh1A3t3o5RQL+bInTebGAAeQekHS8SqYjDUT/KZWfyPetpuOxMqNKYyx1lADVnijXsfczY/akZ60kP1fHQXB2jZxJ1ZABukoA+7c77+WywOLc0qvxmtJefyQhrBaLv6EzFWCw1hkJqw/RhCuAm+LDaNTuOUXyb7jo1zufOrOWQY69A22h2jm05jge/cYlDWBdOjAEh36bRaul9a+uEkIHTe5FoVywVnfzuL9pywc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR0701MB1790;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0701MB1790; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0701MB1790;4:DVD0+lD444wo7jGrg+lTxaBtfpzBN2+cl+2oMguP74RAUZvrLAJS/5Yn1E1zcHWusNWbCQl1Zuw9z+XrAYkaBS8O+fBI6BjdhIDz+Yzj33I9+5LwcpOtYAET00OEQYt+cvVH0F7CL82rmBYRHjveftvmzuLcduEzIhz7ZWeMDAfugudPovXYBipJ+Z27vVECFHQusRZnmENyNOJEgBHz3eDJNF5B4KIr93S7Q1Qp75wfQ21jxYk+BUSpMlWYHO0mj/EnvG/7eJlwqBRBWuPSgp7d0iP0PDlZdjxB2zeF/lN+jjYLwkusHdld0W2Go9K8JIn39dOo2JwtuKoTiIDVCaVs+rWH+IkjUyI8WRLL4sB+52xauPlrrgaJ6aa05ATk X-Forefront-PRVS: 0854128AF0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(479174004)(24454002)(1096002)(4326007)(2950100001)(6116002)(87266999)(92566002)(36756003)(3846002)(65816999)(230700001)(2906002)(77096005)(50466002)(59896002)(83506001)(33656002)(5008740100001)(5001770100001)(80316001)(189998001)(4001350100001)(5001960100002)(40100003)(47776003)(5004730100002)(87976001)(54356999)(65956001)(66066001)(122386002)(65806001)(586003)(42186005)(50986999)(76176999)(93886004);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0701MB1790;H:[10.18.104.43];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR0701MB1790;23:5ee2Ima/JHEMUgFnSWI2HlI1PREEgnUYSrC?= =?Windows-1252?Q?boeQJhw2FU5miVa0crwwtfPfALL4TaH9w6MVX1D+pVDGoobxy1PHaM8F?= =?Windows-1252?Q?6r08PUQGznviI/5UdhZ9xAIxkEdJ5a4l02y44QKPkpL0pdmh/Ikq1o4s?= =?Windows-1252?Q?5QYoh9jSkL5EVIKXhBPO7iAtQXxUeGmVlu6yLVXStAFFBhUi0Zk9s182?= =?Windows-1252?Q?fA4IGjEvLrX4gRqj7w2s/I9BA2eGar5yGGvw73tIjqaeoEl4HyIdAlQ8?= =?Windows-1252?Q?S/U21heXsJll01/IqsXP2yCwvqDfiluudgLCzUi8xhBQP72rZYXy2xBN?= =?Windows-1252?Q?3p0umgA7KBmEvAuuc0qCo/UIZTHJAB51A/JUmSJJ56/Yd3fWRJ0Wi1vA?= =?Windows-1252?Q?xtdeHYu8FYNC7WSJ1LkHFiKVTnS8+HRpTGs+UbhWMh5/f5uOIiljarfw?= =?Windows-1252?Q?lgS0wr78UavG3ewOQW9Y4V1qV/i11vdfpNA0kMDiLFGyuChUVbQi5/cj?= =?Windows-1252?Q?2azo5z/hs2T8Xlt6fXtbW+UjGbYHW6r6N2+iPYfyOIuxvjl/lWLzjr5O?= =?Windows-1252?Q?rn7ukzeJus300OHVOGNkrzAs/9NStRP3NnZWPFTqi3rp0chSLpGCL0Yc?= =?Windows-1252?Q?Zj/gQ7pzDQEvlW0e8OqjClLZ2aXi+zLm0AvoGw7mvHu9FLeVN+OUI/qC?= =?Windows-1252?Q?hFxMPNCYg/897MUErwH/df9w7FnOaJbVT0vwGxezsOaLeUHgWut+Ornz?= =?Windows-1252?Q?gIoOcyNxpJYe1UGDfMuvm8crsxe3uwxN745nCi5ZVxtNojSjsHn2yp+n?= =?Windows-1252?Q?gyod4Q6BQ9IzzsTzTO+8m99mzLwdCV5imgglHSbJdiYtTPjc/TBd9BVA?= =?Windows-1252?Q?Rb2qYfiovpyW3zwaH8n0hldkYGGXIZUkNlDGIC1dFF+hZreYTZFS6dfi?= =?Windows-1252?Q?8DyCOiD6JkephmXZj4/xRPtB/mNegwVd4i6mPhJxyDVbQxfqiF3p5l/S?= =?Windows-1252?Q?in/kwnTh6nAPsFAyw7xkjsEwVPJQgkkJAEbKdozeKcV6DXKyUQsgzYpj?= =?Windows-1252?Q?Ov50eka8HobeSXxDBij3ZENeIg90JV7fcn1hO09Yqs1T+8ZXZmPS0srE?= =?Windows-1252?Q?YmT4T78GLQpEQRhTnSC7mGv0Gb1pkI4lswQdCUaDO3MNmR5dzHs+wDkh?= =?Windows-1252?Q?gtOB4wtrt3BCgXmsW0H1/V+o5rq7IjFk=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0701MB1790;5:5G2JA8v5CLrdzAhW2wM15uQdi0pgtrb8By2yiFLCldaDYNHcnzri1xnLXA69by4nKGgcMUp8qBLmZgaTcxbrKWdhSzHUME3JpWD1r0gmKpOCm9xgnAqKrU7Ki5WvB+U4VpRH++mqfZh1t5P44P5bow==;24:bxPwGV84APFDgK9fxTtKGXClLjjCPYCCbArOfvAxRuOw1fxjlYwEyCQRWjyqPx6DwP9JhfyeK6RdzxLhGBUWcnvB9OgP6iHkWW3z+of1yaQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2016 19:14:48.4505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1790 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2016 06:42 AM, Robert Richter wrote: > On 15.02.16 13:30:41, Tejun Heo wrote: >> On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: >>> There is no need for special Driver, AHCI is sufficient for ThunderX, the >>> file only contains this interrupt handler, >>> is it preferable if this interrupt handler in libahci.c with others, instead >>> of separate file? >> >> Yeap, just fold it in ahci.c with surrounding #ifdef guard. > > Yes, please use #ifdef CONFIG_CAVIUM_ERRATUM_22536 ... and add a > kconfig entry for this to arch/arm64/Kconfig. > Are you sure, this is not a workaround that is based on alternative framework rather on pci device and vendor do you think CONFIG_ARCH_THUNDER a good alternative? > -Robert >