From: David Ahern <dsa@cumulusnetworks.com>
To: David Lamparter <equinox@diac24.net>
Cc: netdev@vger.kernel.org, david@opensourcerouting.org
Subject: Re: [net-next] net: l3mdev: address selection should only consider devices in L3 domain
Date: Tue, 16 Feb 2016 16:49:03 -0700 [thread overview]
Message-ID: <56C3B56F.4020106@cumulusnetworks.com> (raw)
In-Reply-To: <20160216234115.GI659150@eidolon>
On 2/16/16 4:41 PM, David Lamparter wrote:
> ... this won't do enough. If you look at the 4.3 patch I sent you, I
> was adding a comment:
>
> + /* For VRFs, the VRF device takes the place of the loopback device,
> + with addresses on it being preferred. Note in such cases the
> + loopback device will be among the devices that fail the vrf_ifi
> + equality check in the loop below.
> + */
>
Sure, I was focused on fixing the 'ignore devices not in the VRF' but
certainly for unnumbered use cases you want the VRF loopback address to
be preferred. Missed that earlier.
Rather than spinning a patch on top of mine, fold this change into your
and make it 1 patch to achieve the goal.
next prev parent reply other threads:[~2016-02-16 23:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 22:59 [net-next] net: l3mdev: address selection should only consider devices in L3 domain David Ahern
2016-02-16 23:41 ` David Lamparter
2016-02-16 23:48 ` [net-next] net: l3mdev: prefer VRF master for source address selection David Lamparter
2016-02-16 23:49 ` David Ahern [this message]
2016-02-17 1:05 ` [net-next] net: l3mdev: address selection should only consider devices in L3 domain David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3B56F.4020106@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=david@opensourcerouting.org \
--cc=equinox@diac24.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.