From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos Date: Tue, 16 Feb 2016 23:23:24 -0300 Message-ID: <56C3D99C.3090403@osg.samsung.com> References: <1455636348-14277-1-git-send-email-javier@osg.samsung.com> <56C3D745.7050904@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56C3D745.7050904-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andi Shyti , Alim Akhtar , Kukjin Kim , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Hello Krzysztof, On 02/16/2016 11:13 PM, Krzysztof Kozlowski wrote: [snip] >> diff --git a/arch/arm/boot/dts/exynos-syscon-restart.dtsi b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> new file mode 100644 >> index 000000000000..09a2040054ed >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> @@ -0,0 +1,27 @@ >> +/* >> + * Samsung's Exynos SoC syscon reboot/poweroff nodes common definition. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/ { >> + soc { >> + compatible = "simple-bus"; > > The exynos4 does not have soc node. I wonder whether we should provide > here also address and size: > #address-cells = <1>; > #size-cells = <1>; > ranges; > > Without this it works fine but that does not look correct enough. > > A minor effect of this patch on Exynos4 is that syscon-poweroff/reboot > are now the only children of "soc" simple-bus (rest of platform devices > is not)... but this is not a problem. > > Works fine so only the question about cells/ranges remains. Any comments? > I in fact had the #address-cells and #size-cells at the beginning but then realized that both the syscon-poweroff and syscon-reboot nodes didn't have a reg property so it felt strange to me to have those. Also, I thought that maybe a SoC dtsi may need a different #address-cells and #size-cells for the other child nodes so having those in this dtsi could override the values in the SoC dtsi depending where is included. So I thought it could do more harm than good but I've no strong opinion and can add those if you prefer. > Best regards, > Krzysztof > > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Tue, 16 Feb 2016 23:23:24 -0300 Subject: [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos In-Reply-To: <56C3D745.7050904@samsung.com> References: <1455636348-14277-1-git-send-email-javier@osg.samsung.com> <56C3D745.7050904@samsung.com> Message-ID: <56C3D99C.3090403@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Krzysztof, On 02/16/2016 11:13 PM, Krzysztof Kozlowski wrote: [snip] >> diff --git a/arch/arm/boot/dts/exynos-syscon-restart.dtsi b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> new file mode 100644 >> index 000000000000..09a2040054ed >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> @@ -0,0 +1,27 @@ >> +/* >> + * Samsung's Exynos SoC syscon reboot/poweroff nodes common definition. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/ { >> + soc { >> + compatible = "simple-bus"; > > The exynos4 does not have soc node. I wonder whether we should provide > here also address and size: > #address-cells = <1>; > #size-cells = <1>; > ranges; > > Without this it works fine but that does not look correct enough. > > A minor effect of this patch on Exynos4 is that syscon-poweroff/reboot > are now the only children of "soc" simple-bus (rest of platform devices > is not)... but this is not a problem. > > Works fine so only the question about cells/ranges remains. Any comments? > I in fact had the #address-cells and #size-cells at the beginning but then realized that both the syscon-poweroff and syscon-reboot nodes didn't have a reg property so it felt strange to me to have those. Also, I thought that maybe a SoC dtsi may need a different #address-cells and #size-cells for the other child nodes so having those in this dtsi could override the values in the SoC dtsi depending where is included. So I thought it could do more harm than good but I've no strong opinion and can add those if you prefer. > Best regards, > Krzysztof > > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965043AbcBQCXh (ORCPT ); Tue, 16 Feb 2016 21:23:37 -0500 Received: from lists.s-osg.org ([54.187.51.154]:48619 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964967AbcBQCXf (ORCPT ); Tue, 16 Feb 2016 21:23:35 -0500 Subject: Re: [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1455636348-14277-1-git-send-email-javier@osg.samsung.com> <56C3D745.7050904@samsung.com> From: Javier Martinez Canillas Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Alim Akhtar , Kukjin Kim , linux-arm-kernel@lists.infradead.org Message-ID: <56C3D99C.3090403@osg.samsung.com> Date: Tue, 16 Feb 2016 23:23:24 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56C3D745.7050904@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 02/16/2016 11:13 PM, Krzysztof Kozlowski wrote: [snip] >> diff --git a/arch/arm/boot/dts/exynos-syscon-restart.dtsi b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> new file mode 100644 >> index 000000000000..09a2040054ed >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >> @@ -0,0 +1,27 @@ >> +/* >> + * Samsung's Exynos SoC syscon reboot/poweroff nodes common definition. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/ { >> + soc { >> + compatible = "simple-bus"; > > The exynos4 does not have soc node. I wonder whether we should provide > here also address and size: > #address-cells = <1>; > #size-cells = <1>; > ranges; > > Without this it works fine but that does not look correct enough. > > A minor effect of this patch on Exynos4 is that syscon-poweroff/reboot > are now the only children of "soc" simple-bus (rest of platform devices > is not)... but this is not a problem. > > Works fine so only the question about cells/ranges remains. Any comments? > I in fact had the #address-cells and #size-cells at the beginning but then realized that both the syscon-poweroff and syscon-reboot nodes didn't have a reg property so it felt strange to me to have those. Also, I thought that maybe a SoC dtsi may need a different #address-cells and #size-cells for the other child nodes so having those in this dtsi could override the values in the SoC dtsi depending where is included. So I thought it could do more harm than good but I've no strong opinion and can add those if you prefer. > Best regards, > Krzysztof > > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America