From mboxrd@z Thu Jan 1 00:00:00 1970 From: majun258@huawei.com (majun (F)) Date: Wed, 17 Feb 2016 12:18:52 +0800 Subject: [PATCH v2 4/5] irqchip:create irq domain for each mbigen device In-Reply-To: <20160216085024.3f573f40@arm.com> References: <1455604648-20668-1-git-send-email-majun258@huawei.com> <1455604648-20668-5-git-send-email-majun258@huawei.com> <20160216085024.3f573f40@arm.com> Message-ID: <56C3F4AC.8020807@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2016/2/16 16:50, Marc Zyngier ??: > On Tue, 16 Feb 2016 14:37:27 +0800 > MaJun wrote: > >> From: Ma Jun [...] >> + unsigned int nid; >> + >> + nid = get_mbigen_nid(hwirq); >> + >> + if (nid < 4) >> + return (nid * 4) + REG_MBIGEN_VEC_OFFSET; >> + else >> + return (nid - 4) * 4 + REG_MBIGEN_EXT_VEC_OFFSET; >> +} >> + >> +static struct irq_chip mbigen_irq_chip = { >> + .name = "mbigen-v1", >> +}; >> + >> +static void mbigen_write_msg(struct msi_desc *desc, struct msi_msg *msg) >> +{ >> + /* The address of doorbell is encoded in mbigen register by default >> + * So,we don't need to program the doorbell address at here >> + * Besides, the event ID is decided by the hardware pin number, >> + * we can't change it in software.So, we don't need to encode the >> + * event ID in mbigen register. >> + */ > > Really? What if tomorrow I decide to change the EventID allocation > policy in the ITS driver? Have your HW engineers really baked the > behaviour of the Linux driver into the device? > Yes. If we really need to support this chip,is there any possible solution for this problem? Thanks! MaJun > I'm puzzled. > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965164AbcBQEUM (ORCPT ); Tue, 16 Feb 2016 23:20:12 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:31723 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965095AbcBQEUL (ORCPT ); Tue, 16 Feb 2016 23:20:11 -0500 Subject: Re: [PATCH v2 4/5] irqchip:create irq domain for each mbigen device To: Marc Zyngier References: <1455604648-20668-1-git-send-email-majun258@huawei.com> <1455604648-20668-5-git-send-email-majun258@huawei.com> <20160216085024.3f573f40@arm.com> CC: , , , , , , , , , , , , From: "majun (F)" Message-ID: <56C3F4AC.8020807@huawei.com> Date: Wed, 17 Feb 2016 12:18:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160216085024.3f573f40@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.235.245] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56C3F4BA.011A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 89a2a87574b95b7a016fb286224a375c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/2/16 16:50, Marc Zyngier 写道: > On Tue, 16 Feb 2016 14:37:27 +0800 > MaJun wrote: > >> From: Ma Jun [...] >> + unsigned int nid; >> + >> + nid = get_mbigen_nid(hwirq); >> + >> + if (nid < 4) >> + return (nid * 4) + REG_MBIGEN_VEC_OFFSET; >> + else >> + return (nid - 4) * 4 + REG_MBIGEN_EXT_VEC_OFFSET; >> +} >> + >> +static struct irq_chip mbigen_irq_chip = { >> + .name = "mbigen-v1", >> +}; >> + >> +static void mbigen_write_msg(struct msi_desc *desc, struct msi_msg *msg) >> +{ >> + /* The address of doorbell is encoded in mbigen register by default >> + * So,we don't need to program the doorbell address at here >> + * Besides, the event ID is decided by the hardware pin number, >> + * we can't change it in software.So, we don't need to encode the >> + * event ID in mbigen register. >> + */ > > Really? What if tomorrow I decide to change the EventID allocation > policy in the ITS driver? Have your HW engineers really baked the > behaviour of the Linux driver into the device? > Yes. If we really need to support this chip,is there any possible solution for this problem? Thanks! MaJun > I'm puzzled. > > M. >