From: Nikolay Borisov <kernel@kyup.com>
To: David Miller <davem@davemloft.net>
Cc: netfilter-devel@vger.kernel.org, ebiederm@xmission.com,
pabeni@redhat.com, jmorris@namei.org
Subject: Re: [PATCH 0/6] Namespacify various ip sysctl knobs
Date: Wed, 17 Feb 2016 09:47:41 +0200 [thread overview]
Message-ID: <56C4259D.9080202@kyup.com> (raw)
In-Reply-To: <20160216.204328.1217913168570304116.davem@davemloft.net>
On 02/17/2016 03:43 AM, David Miller wrote:
> From: Nikolay Borisov <kernel@kyup.com>
> Date: Mon, 15 Feb 2016 12:02:57 +0200
>
>> This series continues namespacifying more net related knobs.
>> The focus here is on ip options. Patches 1,3,4,5 namespacify
>> the respective sysctl knobs. Patch 2 moves some igmp code to the
>> correct file (and function) and also adds some #ifdef guards to
>> silence compilation warnings.
>>
>> Finally, patch 5 exposes the ip fragmentation related sysctls
>> since all of the knobs are namespaced.
>
> Series applied, but I found Arnd's fix for the unused local variable
> problems much nicer. I wish you had fixed it that way.
I agree, but frankly I haven't really thought about that, but will keep
it in mind the next time I deal with code :)
Can't you apply his fix on top of my commit?
next prev parent reply other threads:[~2016-02-17 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 10:02 [PATCH 0/6] Namespacify various ip sysctl knobs Nikolay Borisov
2016-02-15 10:02 ` [PATCH 1/6] ipv4: Namespaceify ip_default_ttl sysctl knob Nikolay Borisov
2016-02-15 10:02 ` [PATCH 2/6] igmp: net: Move igmp namespace init to correct file Nikolay Borisov
2016-02-15 10:03 ` [PATCH 3/6] ipv4: Namespacify ip_dynaddr sysctl knob Nikolay Borisov
2016-02-15 10:03 ` [PATCH 4/6] ipv4: namespacify ip_early_demux " Nikolay Borisov
2016-02-15 10:03 ` [PATCH 5/6] ipv4: namespacify ip fragment max dist " Nikolay Borisov
2016-02-15 10:03 ` [PATCH 6/6] net: Export ip fragment sysctl to unprivileged users Nikolay Borisov
2016-02-17 1:43 ` [PATCH 0/6] Namespacify various ip sysctl knobs David Miller
2016-02-17 5:14 ` Eric W. Biederman
2016-02-17 7:47 ` Nikolay Borisov [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-15 10:11 Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4259D.9080202@kyup.com \
--to=kernel@kyup.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.