From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Griffin Subject: Re: [PATCH] qat pmd:Fixing build issue on 32-bit systems Date: Wed, 17 Feb 2016 13:29:14 +0000 Message-ID: <56C475AA.2040506@intel.com> References: <1455615876-29879-1-git-send-email-john.griffin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EDFC92C7A for ; Wed, 17 Feb 2016 14:29:17 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, Sure - will resubmit a v2 with those modifications. Thanks, John. On 16/02/16 15:52, De Lara Guarch, Pablo wrote: > Hi John, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin >> Sent: Tuesday, February 16, 2016 9:45 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems >> >> Fixing build issue on 32-bit systems. >> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") >> >> Signed-off-by: John Griffin > Acked-by: Pablo de Lara > > Could you include the error that you are fixing on this patch? > > For example: > > drivers/crypto/qat/qat_crypto.c:345:13: > error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > > Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix". > e.g. (qat: fix build on 32-bit systems). > > Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2. > > Thanks! > Pablo >