From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: julia.lawall@lip6.fr
Subject: Re: [PATCH] lance: Return correct error code
Date: Wed, 17 Feb 2016 17:16:21 +0300 [thread overview]
Message-ID: <56C480B5.7000902@cogentembedded.com> (raw)
In-Reply-To: <20160217133516.GA31497@amitoj-Inspiron-3542>
Hello.
On 2/17/2016 4:35 PM, Amitoj Kaur Chawla wrote:
> The return value of kzalloc on failure should be -ENOMEM and
kzalloc() returns NULL on failure! You need to clarify your patch
description, so that it makes some sense.
> not -ENODEV.
>
> Additionally, removed the following checkpatch warnings:
> ERROR: spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> CHECK: Comparison to NULL could be written "!lp"
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-17 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 13:35 [PATCH] lance: Return correct error code Amitoj Kaur Chawla
2016-02-17 14:16 ` Sergei Shtylyov [this message]
2016-02-17 14:24 ` Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C480B5.7000902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amitoj1606@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.