From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent
Date: Wed, 17 Feb 2016 09:52:20 -0500 [thread overview]
Message-ID: <56C48924.9000600@oracle.com> (raw)
In-Reply-To: <1455719856-20465-1-git-send-email-cardoe@cardoe.com>
On 02/17/2016 09:37 AM, Doug Goldstein wrote:
> The function names were inconsistent with acquire and release being
> called acquire_pmu_ownership() and release_pmu_ownship() respectively.
> Function prototypes were available for both spellings so this change
> makes them consistent and drops the dual function prototypes.
> Additionally change the internal variable names within those functions
> to ownership as well.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
although I think
>
> diff --git a/xen/common/xenoprof.c b/xen/common/xenoprof.c
> index 19b4605..7a3fc86 100644
> --- a/xen/common/xenoprof.c
> +++ b/xen/common/xenoprof.c
> @@ -50,16 +50,16 @@ static u64 passive_samples;
> static u64 idle_samples;
> static u64 others_samples;
>
> -int acquire_pmu_ownership(int pmu_ownship)
> +int acquire_pmu_ownership(int pmu_ownership)
> {
>
using 'new_pmu_owner' as argument might be slightly better.
-boris
next prev parent reply other threads:[~2016-02-17 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 14:37 [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent Doug Goldstein
2016-02-17 14:37 ` Doug Goldstein
2016-02-17 14:37 ` [PATCH v3 2/3] xenoprof: fix up ability to disable it Doug Goldstein
2016-02-17 14:55 ` Andrew Cooper
2016-02-17 14:37 ` Doug Goldstein
2016-02-17 14:37 ` [PATCH v3 3/3] build: convert xenoprof to Kconfig Doug Goldstein
2016-02-17 14:37 ` Doug Goldstein
2016-02-17 15:14 ` Jan Beulich
2016-02-17 14:50 ` [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent Andrew Cooper
2016-02-17 14:52 ` Boris Ostrovsky [this message]
2016-02-18 6:36 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C48924.9000600@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.