From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3qK-0000rh-Id for qemu-devel@nongnu.org; Wed, 17 Feb 2016 10:16:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW3qG-0004qB-Hg for qemu-devel@nongnu.org; Wed, 17 Feb 2016 10:16:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3qG-0004q0-CT for qemu-devel@nongnu.org; Wed, 17 Feb 2016 10:16:36 -0500 References: <1455722040-31820-1-git-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <56C48ECF.8030903@redhat.com> Date: Wed, 17 Feb 2016 16:16:31 +0100 MIME-Version: 1.0 In-Reply-To: <1455722040-31820-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rules: filter out irrelevant files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Michael Tokarev , Victor Kaplansky , Fam Zheng On 17/02/2016 16:15, Michael S. Tsirkin wrote: > It's often handy to make executables depend on each other, e.g. make a > test depend on a helper. This doesn't work now, as linker > will attempt to use the helper as an object. > To fix, filter only relevant file types before linking an executable. Can you provide an example of what you're trying to do? Paolo > Signed-off-by: Michael S. Tsirkin > --- > rules.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules.mak b/rules.mak > index fc5ee41..d1ff311 100644 > --- a/rules.mak > +++ b/rules.mak > @@ -102,7 +102,7 @@ LD_REL := $(CC) -nostdlib -Wl,-r > modules: > > %$(EXESUF): %.o > - $(call LINK,$^) > + $(call LINK,$(filter %.o %.a %.mo, $^)) > > %.a: > $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^," AR $(TARGET_DIR)$@") >