From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW48i-0008A1-Pr for qemu-devel@nongnu.org; Wed, 17 Feb 2016 10:35:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW48h-0001VC-Vi for qemu-devel@nongnu.org; Wed, 17 Feb 2016 10:35:40 -0500 References: <1455646106-2047-1-git-send-email-mreitz@redhat.com> <1455646106-2047-2-git-send-email-mreitz@redhat.com> <20160217100907.GB29494@noname.str.redhat.com> From: Max Reitz Message-ID: <56C49341.2020001@redhat.com> Date: Wed, 17 Feb 2016 16:35:29 +0100 MIME-Version: 1.0 In-Reply-To: <20160217100907.GB29494@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LjuDisTT0F9x8NLmWMJNjkJ99f1d1LxKG" Subject: Re: [Qemu-devel] [PATCH v3 01/14] monitor: Use BB list for BB name completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LjuDisTT0F9x8NLmWMJNjkJ99f1d1LxKG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 17.02.2016 11:09, Kevin Wolf wrote: > Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >=20 > In the long run, I guess we want to have to separate types, one of whic= h > accepts only BlockBackend names and the other one BB and BDS names. Well, for the second type we shouldn't use bdrv_next() either but bdrv_next_node() instead (and bdrv_get_node_name() instead of bdrv_get_device_name()). Max > Though I think that most HMP commands currently require a BB, so this > patch is okay for now. >=20 > Kevin >=20 --LjuDisTT0F9x8NLmWMJNjkJ99f1d1LxKG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWxJNBAAoJEDuxQgLoOKytiv0H/0jvmlRniDJI+FGasiRN85mo hke3xpHY1ZO1U2OCkRo7YTVcrPijTNZKR9HmE7VgwUWcLotrwP+tEgOxQuxr0Eqn wyN5xzbdUaA44ATPN3V+80VGKPT7o6rILFiz20X/cWsPd0IMJeNC8ZD9g3zvpwUg UuVfVsuUx3HS8bxiEOJthXKBmw+CMkUnsRjw5qNH7Yk27pgJ6+C7GJRCJd8w0C0e 7IB/lTpTsiPS8mZQ3tu7ifWAt0++JlrBplvVhLeL8X4WaKLGnw4mlHgJ5nGo2W4i J9Niq+1Tl9sdDjl7dh+8B2BCmcqhe9LySuVJ38im87rTkfxkrzsOoJZfC8FRBeQ= =tz/t -----END PGP SIGNATURE----- --LjuDisTT0F9x8NLmWMJNjkJ99f1d1LxKG--