From: Murali Karicheri <m-karicheri2@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Laight <David.Laight@aculab.com>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>, "Cooper Jr.,
Franklin" <fcooper@ti.com>, "Nori, Sekhar" <nsekhar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kwok, WingMan" <w-kwok2@ti.com>,
"N, Mugunthan V" <mugunthanvnm@ti.com>
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
Date: Wed, 17 Feb 2016 11:19:57 -0500 [thread overview]
Message-ID: <56C49DAD.8050901@ti.com> (raw)
In-Reply-To: <4072312.pCFuaqSbhC@wuerfel>
On 02/09/2016 02:38 PM, Arnd Bergmann wrote:
> On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
>> The descriptors are usable by different drivers, one driver may use it as
>> buf ptr/ len, other for something else. So they should remain as generic
>> and it is up to individual drivers to use it in whatever way it requires.
>> My suggestion is to rename pad field in struct knav_dma_desc to sw_data
>> to avoid confusion. i.e
>>
>> + __le32 pad[4];
>>
>> to
>>
>> + __le32 sw_data[4];
>>
> If the hardware doesn't access them, they can probably just be u32
> and not do any byte swapping.
Agree.
>
> Arnd
>
--
Murali Karicheri
Linux Kernel, Keystone
next prev parent reply other threads:[~2016-02-17 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 13:58 [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Grygorii Strashko
2016-02-09 14:13 ` David Laight
2016-02-09 16:09 ` Karicheri, Muralidharan
2016-02-09 16:10 ` David Laight
2016-02-09 16:19 ` Karicheri, Muralidharan
2016-02-09 16:37 ` David Laight
2016-02-09 16:55 ` Karicheri, Muralidharan
2016-02-09 19:38 ` Arnd Bergmann
2016-02-10 8:33 ` Grygorii Strashko
2016-02-17 16:19 ` Murali Karicheri [this message]
2016-02-18 17:02 ` Murali Karicheri
2016-02-16 20:24 ` David Miller
2016-02-18 17:13 ` Murali Karicheri
2016-02-18 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C49DAD.8050901@ti.com \
--to=m-karicheri2@ti.com \
--cc=David.Laight@aculab.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fcooper@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.