Re: [Outreachy kernel] [PATCH] staging: unisys: Modify boolean assignment

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/10/16 03:54, Julia Lawall wrote:
> 
> 
> On Tue, 9 Feb 2016, Janani Ravichandran wrote:
> 
>>
>>
>> On Wednesday, 10 February 2016 02:26:38 UTC-5, Julia Lawall wrote:
>>       On Wed, 10 Feb 2016, Janani Ravichandran wrote:
>>
>>       > Boolean variables should be assigned true/false rather than
>>       1/0.
>>       > This patch makes such a correction.
>>
>>       A change like this should be made consistently, so it is a
>>       little
>>       surprising to see only one such change.  Is this the only place
>>       where the
>>       variable is initialized?  
>>
>> Within this file, this is the only instance of initialization of the
>> variable where 1 is
>>  used instead of true. All others use true/false. I sent this to resolve
>> that
>> inconsistency :)
>>       If so, you could say that.  if not, then you
>>       could explain that all of the other initialization places
>>       already have
>>       boolean values, in some way or another.
>>
>> Do I send a v2 explaining this?
> 
> I think it could be helpful.

You also need to CC the driver author, not just the outreachy list.

Jes