From: Rick Jones <rick.jones2@hpe.com>
To: Or Gerlitz <ogerlitz@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>, Amir Vadai <amir@vadai.me>,
Eugenia Emantayev <eugenia@mellanox.com>
Subject: Re: [PATCH net V1 1/6] net/mlx4_en: Count HW buffer overrun only once
Date: Wed, 17 Feb 2016 10:04:34 -0800 [thread overview]
Message-ID: <56C4B632.8030700@hpe.com> (raw)
In-Reply-To: <1455722667-23179-2-git-send-email-ogerlitz@mellanox.com>
On 02/17/2016 07:24 AM, Or Gerlitz wrote:
> From: Amir Vadai <amir@vadai.me>
>
> RdropOvflw counts overrun of HW buffer, therefore should
> be used for rx_fifo_errors only.
>
> Currently RdropOvflw counter is mistakenly also set into
> rx_missed_errors and rx_over_errors too, which makes the
> device total dropped packets accounting to show wrong results.
>
> Fix that. Use it for rx_fifo_errors only.
>
> Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')
> Signed-off-by: Amir Vadai <amir@vadai.me>
> Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-By: Rick Jones <rick.jones2@hpe.com>
rick
next prev parent reply other threads:[~2016-02-17 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 15:24 [PATCH V1 net 0/6] Mellanox 10/40G mlx4 driver fixes for 4.5-rc Or Gerlitz
2016-02-17 15:24 ` [PATCH net V1 1/6] net/mlx4_en: Count HW buffer overrun only once Or Gerlitz
2016-02-17 18:04 ` Rick Jones [this message]
2016-02-17 15:24 ` [PATCH net V1 2/6] net/mlx4_en: Choose time-stamping shift value according to HW frequency Or Gerlitz
2016-02-17 15:24 ` [PATCH net V1 3/6] net/mlx4_core: Fix potential corruption in counters database Or Gerlitz
2016-02-17 15:24 ` [PATCH net V1 4/6] net/mlx4_core: Do not BUG_ON during reset when PCI is offline Or Gerlitz
2016-02-18 12:45 ` Sergei Shtylyov
2016-02-17 15:24 ` [PATCH net V1 5/6] net/mlx4_core: Set UAR page size to 4KB regardless of system page size Or Gerlitz
2016-02-17 15:24 ` [PATCH net V1 6/6] net/mlx4_en: Avoid changing dev->features directly in run-time Or Gerlitz
2016-02-17 15:30 ` [PATCH V1 net 0/6] Mellanox 10/40G mlx4 driver fixes for 4.5-rc David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4B632.8030700@hpe.com \
--to=rick.jones2@hpe.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.