From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 4/5] VMX: fold redundant code Date: Wed, 17 Feb 2016 18:05:11 +0000 Message-ID: <56C4B657.3030608@citrix.com> References: <56C4AC2802000078000D3473@prv-mh.provo.novell.com> <56C4AFD102000078000D34AD@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56C4AFD102000078000D34AD@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 17/02/16 16:37, Jan Beulich wrote: > No need to do this in two slightly different ways, possibly keeping the > compiler from folding the code for us. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3103,6 +3103,7 @@ void vmx_vmexit_handler(struct cpu_user_ > && vector != TRAP_nmi > && vector != TRAP_machine_check ) It would be nice if you could nuke the two bits of whitespace after the TRAP_* constants while you are editing this area. Reviewed-by: Andrew Cooper