From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 Date: Wed, 17 Feb 2016 10:57:50 -0800 Message-ID: <56C4C2AE.90009@caviumnetworks.com> References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> <56C37524.5090000@caviumnetworks.com> <56C37AD3.4030407@caviumnetworks.com> <56C37D94.8080403@caviumnetworks.com> <20160216211410.GI25086@rric.localdomain> <56C3AD1C.2000003@caviumnetworks.com> <20160217112931.GB31970@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160217112931.GB31970@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: Tirumalesh Chalamarla , stripathi@apm.com, David Daney , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Tejun Heo , Robert Richter , linux-arm-kernel@lists.infradead.org List-Id: linux-ide@vger.kernel.org On 02/17/2016 03:29 AM, Will Deacon wrote: > On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote: >> On 02/16/2016 01:14 PM, Robert Richter wrote: >>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only >>> used for core interrupts, e.g. also for gicv3 devices (and now also >>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not >>> enabled in the arm64 cpu errata framework (not handled in >>> arch/arm64/kernel/cpu_errata.c). >>> >>> Thus, >>> >>> #ifdef CONFIG_CAVIUM_ERRATUM_22536 >>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c) >>> ahci_thunderx_init(&pdev->dev, hpriv); >>> #endif >>> >>> is the correct enablement of the workaround by device id. >>> >>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document. >>> >> The code will only run for Thunder and AHCI, becuase its PCI. > > Well, the guards also serve as documentation for exactly why we're having > to do something special here, so I'd say go ahead and add > CONFIG_CAVIUM_ERRATUM_22536 and update > Documentation/arm64/silicon-errata.txt accordingly. > If the ahci/ata maintainers insist, we can add that. Should we also add some CONFIG_ variables for: ahci_mcp89_apple_enable() ahci_sb600_enable_64bit() ahci_p5wdh_workaround() . . . Surely we would wish to give people the flexibility to trim that code out of the driver if they know that it is not needed. And don't even get me started on drivers/pci/quirks.c ... > > > Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ddaney@caviumnetworks.com (David Daney) Date: Wed, 17 Feb 2016 10:57:50 -0800 Subject: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 In-Reply-To: <20160217112931.GB31970@arm.com> References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> <56C37524.5090000@caviumnetworks.com> <56C37AD3.4030407@caviumnetworks.com> <56C37D94.8080403@caviumnetworks.com> <20160216211410.GI25086@rric.localdomain> <56C3AD1C.2000003@caviumnetworks.com> <20160217112931.GB31970@arm.com> Message-ID: <56C4C2AE.90009@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/17/2016 03:29 AM, Will Deacon wrote: > On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote: >> On 02/16/2016 01:14 PM, Robert Richter wrote: >>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only >>> used for core interrupts, e.g. also for gicv3 devices (and now also >>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not >>> enabled in the arm64 cpu errata framework (not handled in >>> arch/arm64/kernel/cpu_errata.c). >>> >>> Thus, >>> >>> #ifdef CONFIG_CAVIUM_ERRATUM_22536 >>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c) >>> ahci_thunderx_init(&pdev->dev, hpriv); >>> #endif >>> >>> is the correct enablement of the workaround by device id. >>> >>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document. >>> >> The code will only run for Thunder and AHCI, becuase its PCI. > > Well, the guards also serve as documentation for exactly why we're having > to do something special here, so I'd say go ahead and add > CONFIG_CAVIUM_ERRATUM_22536 and update > Documentation/arm64/silicon-errata.txt accordingly. > If the ahci/ata maintainers insist, we can add that. Should we also add some CONFIG_ variables for: ahci_mcp89_apple_enable() ahci_sb600_enable_64bit() ahci_p5wdh_workaround() . . . Surely we would wish to give people the flexibility to trim that code out of the driver if they know that it is not needed. And don't even get me started on drivers/pci/quirks.c ... > > > Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161795AbcBQS55 (ORCPT ); Wed, 17 Feb 2016 13:57:57 -0500 Received: from mail-by2on0091.outbound.protection.outlook.com ([207.46.100.91]:64675 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965208AbcBQS5z (ORCPT ); Wed, 17 Feb 2016 13:57:55 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56C4C2AE.90009@caviumnetworks.com> Date: Wed, 17 Feb 2016 10:57:50 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon CC: Tirumalesh Chalamarla , , David Daney , , , Tejun Heo , Robert Richter , Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 References: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com> <20160214170152.GC3965@htj.duckdns.org> <56C147B2.9010303@caviumnetworks.com> <20160215183041.GH3965@htj.duckdns.org> <20160216144250.GD31343@rric.localdomain> <56C37524.5090000@caviumnetworks.com> <56C37AD3.4030407@caviumnetworks.com> <56C37D94.8080403@caviumnetworks.com> <20160216211410.GI25086@rric.localdomain> <56C3AD1C.2000003@caviumnetworks.com> <20160217112931.GB31970@arm.com> In-Reply-To: <20160217112931.GB31970@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BY2PR07CA039.namprd07.prod.outlook.com (10.141.251.14) To SN1PR07MB2143.namprd07.prod.outlook.com (25.164.47.13) X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;2:Vqu9JrLKTuNP+eieN3kd25o+tXAvElg00E9bIKQWdrs/qNs6rb400i8pDErUQoqW9xJ1VmKeRolxE5WObfrZigbhlROjg1nIWijow5baVMXisKeUru2AuSxUYRAFV2VF7nJI2CCfhYt4sLhmpOFXPw==;3:C0yRD8nc7Fs4pBU1/cGAEZVOAwnPiDTEhuxZQ6ZPj9v6KnV4sc3nYqAjsIgmpPBvwPlHbvcA4BtGAjS0v8PnEHPInki1JGeOl3GmFSSG7zUk2Y6heEM4VflwdklpaJQo;25:fq43cpK5+OOpFLNSSmA4rCQC4nqtxGtREH3VwcdvOyzlK1DmxWCy5rnAMiIT1fUXwcKyYd8FUVINTWNmGEU1Mp2yeHwaZwL4mlCQ8y5rDkZYHpR7kILWZE6epgPLBLHwbY+2jFzmpqHc4BiOMdPkiOswB9lBRH7ehSiflbiSfWKnKBwkVuFw8F3uw4zCimEpA+CpKFi7oPx67HlJhgTupLem6nc3WL+DtYufUKgKXPlua6yhWclDDlKVdb2C7OWwB6gFCm/MQHih9/b0hctpq1VaCmHGo3nI/OvXgAZoFuIC1iiUGqFSJTdszizvzVY2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2143; X-MS-Office365-Filtering-Correlation-Id: fc059941-8eda-4cc5-5e29-08d337cc3ddf X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;20:xIlHL/DYMsddSWrrz+IZMVksExKlPf+peAw2wF9LhOJBfp4i74mK0gJW9YA8avOp86ksC6QxMJdpGAz3cWmP0huPoQnB9Xl6klyoX22QM1klHe2zD362DIHuVfel6Q7Xcem8lZmGyN/5NzArRnfb5Aa+NxhByiQZFIvMB480fGdrAEeQ99UOoIfdovEkRXWEsP6dwnzUe4Iax7asKYmsgOvJoEBTDdTM104mG6+Qk9jtqv5XgdjPgj5715Bv1nKFcuJHfsS+d7f49ifXiV9Rw8M7Pc0bpZ996qRQIL4z8era6iJhqFw6+Od42GfeWz0Ee5QoBiQKXFjhXoxY49q5sOF9GaZE53sg51ZhH3gbfBqplXa2KRzFpfICf4Q+SgF9ViRrH1SiGcrnVn4zWSG5ikl+9HjLY/Q+u2VLxgFhmm6RE0u22PqlNLzk90sRL9D3qMlyU7xAjO7P2Z/zfkA6lRMk/5MwAUen0uWT7p3aVQ3Z55FL9B/mpxR5ArzirPwKAKVAtrW+AFNdV18FYHK1wJkmQBPsZCis6zYsTYhbASZVBEI4/UHCjw9mG8sDFLA3GCamUTybzc+p6h/SQ1mHjLkbwzXcYIC4uIgFxgDy7LI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR07MB2143;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2143; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;4:Oc51juaHwHNOJpe7T7dSe6Z4w/I//5ydTi4KVnEVEvDEvqa07K4BoXQAgRqumDWGxwJdgvlcYFLoovUxWTGsZx6KTY9+eXJpbzXCgcgFE0qeBQX3/hWOBJQvtoO1pS3qNzTiVYzWnoU6b6KAJvfekwKyjDtjY1OlSxzMvrpz3SPGqZvLwLdaEa3QXI8G7JqaHAg7vIgAaa5oE4LFY94ohGEnvzQtuh5ofvLiZjfkfVOis7Sm6bgHERqf4XDcrbKLuOoDX/g1A2IrvVLrP8fj3kuJzKzmRkGWVd2JIpAmfaSQ2GLvbNS1dbrRI6rPYjT/gHoOs5try2JgdCNdJwYakuwSPjKp9a0pTFsn7EtE/aVRI6uXoxNkzTnv08PE0qs4 X-Forefront-PRVS: 085551F5A8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(479174004)(377454003)(47776003)(66066001)(83506001)(230700001)(4326007)(65806001)(65956001)(19580405001)(2950100001)(53416004)(5004730100002)(2906002)(42186005)(1096002)(189998001)(1720100001)(3846002)(6116002)(19580395003)(586003)(33656002)(5001960100002)(122386002)(87976001)(5008740100001)(65816999)(40100003)(77096005)(92566002)(76176999)(110136002)(15975445007)(50986999)(23756003)(54356999)(36756003)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2143;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;SN1PR07MB2143;23:4LgFXr5F6ucK9bKexFidzGpcWEiiV95UYpX3tPT?= =?iso-8859-1?Q?gOYpY8RAXJV8n4uf6pCr22gEMKIbEuQt3ZquFq48iHeCAyadWipxt/tu9Y?= =?iso-8859-1?Q?pzwstUZ25Mw8Ou5BOtKM+Slsgk2bFIIi3RclpWW5U7V3V54y1uaaoY47uZ?= =?iso-8859-1?Q?Illx+EOJXBzrv+oAfk24D2K2jh1NoVP4TgjcgqxrGJ9rKDj5b/EjtNAYY0?= =?iso-8859-1?Q?AIqSIVew5S6CPOogVco/JwSS2/qLgQDfexTmTmlZFhOmapxnMsTXJiqoBu?= =?iso-8859-1?Q?G7SuuVJv6sd0GVoYPaFYBp5L0oM5umq5s3JiwP1cWHk6h+F6Yn74BUlEPR?= =?iso-8859-1?Q?Tt7UjsPBa8cM1qXXuuwOEPAzyrtvz8k2p3ecPnBEzRzEyntaXF958bIDjp?= =?iso-8859-1?Q?tjDa8wcAWdH1wtz7gQrQVZcKftsymP0By7nEosmJRoQCBAbgBluZFasphS?= =?iso-8859-1?Q?A0kcDcnogx8rFscxYKbQlSxTwsyU31oASBP//g0DkwI0PxKPmYVbP215JG?= =?iso-8859-1?Q?XTgsubOSD24qGzqmix/p2H7niDatuXAeUWmtWmqU2BLQTWDeAbCKtVll1T?= =?iso-8859-1?Q?qaVXr0LQzctFokeCrUfA6k7VlCdP78L3kq1Dhbmp/qugif43ZEDB7aknie?= =?iso-8859-1?Q?IVdr2NwOdvQJTPlsZ3Spc491605fqOTtHcXwuO5E/idV4UM/GRPZztnq5+?= =?iso-8859-1?Q?SDZd3kvakyMaYQSRWv1xZFwfHT6xo61qZBVpnDWZEytfdlVObwaEQQPhP3?= =?iso-8859-1?Q?6/aeX2ompZl9nx/aWeTb6FW8rx1YYla0G2kO7Mx8tdehcof6TDrMwzgNuO?= =?iso-8859-1?Q?qPSx2GhK/JwBIN0RU8FzhEOA9imrsI5Tu4SecZgWXR+xy3RniMALdAB7Uy?= =?iso-8859-1?Q?KK6lpc/9DGoE2NvpV6YDcUMHlCWmEVHsExxdIcy097hPKmVWJlSWseBwE9?= =?iso-8859-1?Q?X8SOQAegLCIaze4cj71DiIz8LT3J696/NwZlDjmkrPtKI8jnFKzdl4Qy5d?= =?iso-8859-1?Q?OJ/7CQ0tklwaxU2GH4zn1g6Fc5pgATzX9qZL+6BAAPYFGQIaH/iGDGr4Vb?= =?iso-8859-1?Q?Ij0GmiYsblAzySW8k5LpGHav7Ysr+81l9euuQlbHL4oJsBZFqudgMS7x0o?= =?iso-8859-1?Q?uYj38XPTjZ9TQZASSZdqbNRqjDOAiiD/yt+d6H582yHhpwHF+KOYuyDxT7?= =?iso-8859-1?Q?qbBmT9nlvVV?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;5:jrlhRqMv0nEBf4nsfKVSEJU7jUJFjFPwfgduEOqXVaRf9L4mRoIbZmorbxVIaRQNG/ZcJntDtlAfSTgwIDUYmbgOCYSenKkXBWPRrhm4GXfxg5Lf8ycer8sdA6ZVd7gC63gWWD+CfLUr/1/Rh2hLTA==;24:CzYR9VLlnETm8FiEzeOivuZ6RD7erSuFo2Ma6EF/b7xaq/VdwtIbhEC/rJt9jIpr9x3w02fdu3Zd/9O4NgtQ/j3DfRe0VQBba5vAxyfwiI8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2016 18:57:53.5745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2143 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2016 03:29 AM, Will Deacon wrote: > On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote: >> On 02/16/2016 01:14 PM, Robert Richter wrote: >>> CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only >>> used for core interrupts, e.g. also for gicv3 devices (and now also >>> for ahci). Non-core errata (e.g. CONFIG_CAVIUM_ERRATUM_23144) are not >>> enabled in the arm64 cpu errata framework (not handled in >>> arch/arm64/kernel/cpu_errata.c). >>> >>> Thus, >>> >>> #ifdef CONFIG_CAVIUM_ERRATUM_22536 >>> if (pdev->vendor == 0x177d && pdev->device == 0xa01c) >>> ahci_thunderx_init(&pdev->dev, hpriv); >>> #endif >>> >>> is the correct enablement of the workaround by device id. >>> >>> And, CAVIUM_ERRATUM_* is very easy to handle, enable and document. >>> >> The code will only run for Thunder and AHCI, becuase its PCI. > > Well, the guards also serve as documentation for exactly why we're having > to do something special here, so I'd say go ahead and add > CONFIG_CAVIUM_ERRATUM_22536 and update > Documentation/arm64/silicon-errata.txt accordingly. > If the ahci/ata maintainers insist, we can add that. Should we also add some CONFIG_ variables for: ahci_mcp89_apple_enable() ahci_sb600_enable_64bit() ahci_p5wdh_workaround() . . . Surely we would wish to give people the flexibility to trim that code out of the driver if they know that it is not needed. And don't even get me started on drivers/pci/quirks.c ... > > > Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >