From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] phy: marvell: Add support for phy packet generator
Date: Wed, 17 Feb 2016 23:33:07 +0100 [thread overview]
Message-ID: <56C4F523.802@gmx.de> (raw)
In-Reply-To: <1455741127-25453-3-git-send-email-andrew@lunn.ch>
Hi,
On 17.02.2016 21:32, Andrew Lunn wrote:
> +
> + oldpage = phy_read(phydev, MII_MARVELL_PHY_PAGE);
> + if (oldpage < 0) {
> + err = oldpage;
> + goto out;
> + }
> +
shouldn't this return immediately? Jump to out label and writing an
error value to the phy does not seem to be correct.
Regards,
Lino
next prev parent reply other threads:[~2016-02-17 22:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 20:32 [PATCH net-next 0/2] Add support for PHY packet generators Andrew Lunn
2016-02-17 20:32 ` [PATCH net-next 1/2] net: ethtool: " Andrew Lunn
2016-02-17 21:06 ` Ben Hutchings
2016-02-17 21:55 ` Andrew Lunn
2016-02-17 23:28 ` Ben Hutchings
2016-02-17 20:32 ` [PATCH net-next 2/2] phy: marvell: Add support for phy packet generator Andrew Lunn
2016-02-17 22:33 ` Lino Sanfilippo [this message]
2016-02-17 23:49 ` Florian Fainelli
2016-02-18 20:45 ` [PATCH net-next 0/2] Add support for PHY packet generators David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4F523.802@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.