From: Jim Fehlig <jfehlig@suse.com>
To: Ian Campbell <ian.campbell@citrix.com>, libvir-list@redhat.com
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 0/4] libxl: support qemu's network-based block backends
Date: Wed, 17 Feb 2016 17:34:42 -0700 [thread overview]
Message-ID: <56C511A2.5090801@suse.com> (raw)
In-Reply-To: <1455704693.814.153.camel@citrix.com>
On 02/17/2016 03:24 AM, Ian Campbell wrote:
> On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote:
>> xl/libxl already supports qemu's network-based block backends
>> such as nbd and rbd. libvirt has supported configuring network
>> disks for long time too. This series marries the two in the
>> libxl driver and in the xl<->xml converter. Only rbd supported
>> is added in this series. Support for other backends such as nbd
>> and iscsi can be added as a follow-up improvement.
> This all looks sensible to me, FWIW.
Thanks for taking a look!
>
> One question, in patch 3's commit log should the example be double escaping
> the \\ or not? Based on your updates to $xen/docs/misc/xl-disk-
> configuration.txt (posted separately on xen-devel) I had expected they
> would.
Yes, you are correct. The test and conversion code in patch 3 is wrong in that
regard too. I've fixed it in V2.
Regards,
Jim
next prev parent reply other threads:[~2016-02-18 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 21:45 [PATCH 0/4] libxl: support qemu's network-based block backends Jim Fehlig
2016-02-16 21:45 ` [PATCH 1/4] xenconfig: replace text 'xm' with 'xl' in xlconfigtest Jim Fehlig
2016-02-16 21:45 ` [PATCH 2/4] xenconfig: produce key=value disk config syntax in xl formatter Jim Fehlig
2016-02-16 21:45 ` [PATCH 3/4] xenconfig: support xl<->xml conversion of rbd disk devices Jim Fehlig
2016-02-26 17:40 ` [libvirt] " Daniel P. Berrange
2016-02-16 21:45 ` [PATCH 4/4] libxl: add support for rbd qdisk Jim Fehlig
2016-02-26 17:44 ` [libvirt] " Daniel P. Berrange
2016-02-17 10:24 ` [PATCH 0/4] libxl: support qemu's network-based block backends Ian Campbell
[not found] ` <1455704693.814.153.camel@citrix.com>
2016-02-18 0:34 ` Jim Fehlig [this message]
[not found] ` <1455659159-11931-2-git-send-email-jfehlig@suse.com>
2016-02-26 17:35 ` [libvirt] [PATCH 1/4] xenconfig: replace text 'xm' with 'xl' in xlconfigtest Daniel P. Berrange
[not found] ` <1455659159-11931-3-git-send-email-jfehlig@suse.com>
2016-02-26 17:39 ` [libvirt] [PATCH 2/4] xenconfig: produce key=value disk config syntax in xl formatter Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C511A2.5090801@suse.com \
--to=jfehlig@suse.com \
--cc=ian.campbell@citrix.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.