From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v8 0/2] Add Rockchip Inno-HDMI driver Date: Thu, 18 Feb 2016 14:12:02 +0800 Message-ID: <56C560B2.6020208@rock-chips.com> References: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDAx5pyIMjnml6UgMTQ6NDIsIFlha2lyIFlhbmcgd3JvdGU6Cj4gSGVyZSBhcmUg YSBicmllZiBpbnRyb2R1Y3Rpb24gdG8gSW5ub3NpbGljb24gSERNSSBJUDoKPiAgICAtIFN1cHBv cnQgSERNSSAxLjRhLCBIRENQIDEuMiBhbmQgRFZJIDEuMCBzdGFuZGFyZCBjb21wbGlhbnQgdHJh bnNtaXR0ZXIKPiAgICAtIFN1cHBvcnQgSERNSTEuNCBhL2IgM0QgZnVuY3Rpb24gZGVmaW5lZCBp biBIRE1JIDEuNCBhL2Igc3BlYwo+ICAgIC0gRGlnaXRhbCB2aWRlbyBpbnRlcmZhY2Ugc3VwcG9y dHMgYSBwaXhlbCBzaXplIG9mIDI0LCAzMCwgMzYsIDQ4Yml0cyBjb2xvciBkZXB0aCBpbiBSR0IK PiAgICAtIFMvUERJRiBvdXRwdXQgc3VwcG9ydHMgUENNLCBEb2xieSBEaWdpdGFsLCBEVFMgZGln aXRhbCBhdWRpbyB0cmFuc21pc3Npb24KPiAgICAgICgzMi0xOTJrSHogRnMpIHVzaW5nIElFQzYw OTU4IGFuZCBJRUMgNjE5MzcKPiAgICAtIFRoZSBFRElEIGFuZCBDRUMgZnVuY3Rpb24gYXJlIGFs c28gc3VwcG9ydGVkIGJ5IElubm9zaWxpY29uIEhETUkgVHJhbnNtaXR0ZXIgQ29udHJvbGxlCj4K PiBDaGFuZ2VzIGluIHY4Ogo+IC0gRG9uJ3QgY2hlY2sgd2hldGhlciBlbmNvZGVyIG91dHB1dCBm b3JtYXQgaXMgUkdCIGNvbG9yc3BhY2UsIGNhdXNlIGRyaXZlcgo+ICAgIGRlZmF1bHQgY29uZmln dXJlIHRoZSBvdXRwdXQgY29sb3JzcGFjZSB0byBSR0IuIChaaGVuZ1lhbmcpCj4gLSBDb3JyZWN0 IHRoZSBjaGVjayBjb25kaXRpb24gaW4gaW5ub19oZG1pX2NvbmZpZ192aWRlb19jc2MoKSAoWmhl bmdZYW5nKQo+ICAgICAgLSBpZiAoZGF0YS0+ZW5jX291dF9mb3JtYXQgPT0gZGF0YS0+ZW5jX291 dF9mb3JtYXQpIHsKPiAgICAgICsgaWYgKGRhdGEtPmVuY19pbl9mb3JtYXQgPT0gZGF0YS0+ZW5j X291dF9mb3JtYXQpIHsKPgo+IENoYW5nZXMgaW4gdjc6Cj4gLSBDb3JyZWN0IHRoZSBtb2R1bGUg bGljbmVzZSBzdGF0ZW1lbnQgKFBhdWwpCj4gICAgICAgLSBNT0RVTEVfTElDRU5TRSgiR1BMIik7 Cj4gICAgICAgKyBNT0RVTEVfTElDRU5TRSgiR1BMdjIiKTsKPiAtIFN0YXJ0IGluZGVudGF0aW9u IHdpdGggdGFicyBhbmQgZml4IHRoZSBtaXNzcGVsbCBpbiBLY29uZmlnIChQYXVsKQo+IC0gQ2Fy cnkgdGhlIGxvc3QgZGV2aWNlLWJpbmRpbmcgZG9jdW1lbnQgKEhlaWtvKQo+Cj4gQ2hhbmdlcyBp biB2NjoKPiAtIFJlYmFzZSB0aGUgTWFrZWZpbGUvS2NvbmZpZyBmaWxlcyB3aGljaCBhZGQgYnkg Q2hyaXMncyByb2NrY2hpcC1taXBpIGRyaXZlciAoQ2Flc2VyKQo+Cj4gQ2hhbmdlcyBpbiB2NToK PiAtIFVzZSBoZG1pX2luZm9mcmFtZSBoZWxwZXIgZnVuY3Rpb25zIHRvIHBhY2tlZCB0aGUgaW5m b2ZyYW1lIChSdXNzZWxsKQo+IC0gUmVtb3ZlIHRoZSB1bnVzZWQgZG91YmxlIHdhaXRfZm9yX2Nv bXBsZXRpb25fdGltZW91dCBmb3IgZGRjIHRyYW5zZmVyIChSdXNzZWxsKQo+IC0gUmVtb3ZlIHRo ZSB1bnVzZWQgbG9jYWwgdmFyaWFibGUgaW4gImlubm9faGRtaV9pMmNfd3JpdGUoKSIgZnVuY3Rp b24gKFJ1c3NlbGwpCj4KPiBDaGFuZ2VzIGluIHY0Ogo+IC0gTW9kaWZ5IHRoZSBjb21taXQgdGl0 bGUgImRybS9yb2NrY2hpcDogaGRtaTogLi4uIiAoTWFyaykKPiAtIENvcnJlY3QgdGhlICJES01T IiB0byAiRFBNUyIgKE1hcmspCj4gLSBGaXggb3ZlciA4MCBjaGFyYWN0ZXJzIHByb2JsZW1zIChN YXJrKQo+IC0gUmVtb3ZlIGVuY29kZXIgLnByZXBhcmUvLmNvbW1pdCBoZWxwZXIgZnVuY3Rpb25z LCBhbmQgbW92ZSB0aGUgdm9wIG1vZGUKPiBjb25maWd1cmUgZnVuY3Rpb24gaW50byBlbmNvZGVy IC5lbmFibGUgaGVscGVyIGZ1bmN0aW9ucy4gKE1hcmspCj4KPiBDaGFuZ2VzIGluIHYzOgo+IC0g VXNlIGVuY29kZXIgZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb24sIGFuZCByZW1vdmUgdGhlIGVuY29k ZXIgRFBNUyBmdW5jdGlvbgo+IC0gS2VlcCBIRE1JIFBMTCBwb3dlciBvbiBpbiBzdGFuZGJ5IG1v ZGUKPgo+IENoYW5nZXMgaW4gdjI6Cj4gLSBVc2luZyBEUk0gYXRvbWljIGhlbHBlciBmdW5jdGlv bnMgZm9yIGNvbm5lY3RvciBpbml0IChNYXJrKQo+IC0gUmVtb3ZlICJoZG1pLT5jb25uZWN0b3Iu ZW5jb2RlciA9IGVuY29kZXI7IiAoTWFyaykKPiAtIEFkZCB0aGUgQWNrZWQtYnkgdGFncyBmcm9t IFJvYgo+IC0gQ29ycmVjdCB0aGUgbWlzc3BlbGwgInJrMzAzNi1kdy1oZG1pIiAoSGVpa28pCj4K PiBZYWtpciBZYW5nICgyKToKPiAgICBkcm0vcm9ja2NoaXA6IGhkbWk6IGFkZCBJbm5vc2lsaWNv biBIRE1JIHN1cHBvcnQKPiAgICBkdC1iaW5kaW5nczogYWRkIGRvY3VtZW50IGZvciBJbm5vc2ls aWNvbiBIRE1JIG9uIFJvY2tjaGlwIHBsYXRmb3JtCj4KPiAgIC4uLi9kaXNwbGF5L3JvY2tjaGlw L2lubm9faGRtaS1yb2NrY2hpcC50eHQgICAgICAgIHwgIDUwICsrCj4gICBkcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvS2NvbmZpZyAgICAgICAgICAgICAgICAgICB8ICAgOCArCj4gICBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZpbGUgICAgICAgICAgICAgICAgICB8ICAgMSArCj4gICBk cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvaW5ub19oZG1pLmMgICAgICAgICAgICAgICB8IDkzOSAr KysrKysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9pbm5vX2hk bWkuaCAgICAgICAgICAgICAgIHwgMzYyICsrKysrKysrCj4gICA1IGZpbGVzIGNoYW5nZWQsIDEz NjAgaW5zZXJ0aW9ucygrKQo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2lubm9faGRtaS1yb2NrY2hpcC50eHQK PiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvaW5ub19oZG1p LmMKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvaW5ub19o ZG1pLmgKPgoKQXBwbGllZCB0byBteSBicmFuY2ggOi0pIC4KClRoYW5rcy4KCi0tIArvvK1hcmsg WWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 18 Feb 2016 14:12:02 +0800 Subject: [PATCH v8 0/2] Add Rockchip Inno-HDMI driver In-Reply-To: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> References: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> Message-ID: <56C560B2.6020208@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?01?29? 14:42, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: > - Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter > - Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec > - Digital video interface supports a pixel size of 24, 30, 36, 48bits color depth in RGB > - S/PDIF output supports PCM, Dolby Digital, DTS digital audio transmission > (32-192kHz Fs) using IEC60958 and IEC 61937 > - The EDID and CEC function are also supported by Innosilicon HDMI Transmitter Controlle > > Changes in v8: > - Don't check whether encoder output format is RGB colorspace, cause driver > default configure the output colorspace to RGB. (ZhengYang) > - Correct the check condition in inno_hdmi_config_video_csc() (ZhengYang) > - if (data->enc_out_format == data->enc_out_format) { > + if (data->enc_in_format == data->enc_out_format) { > > Changes in v7: > - Correct the module licnese statement (Paul) > - MODULE_LICENSE("GPL"); > + MODULE_LICENSE("GPLv2"); > - Start indentation with tabs and fix the misspell in Kconfig (Paul) > - Carry the lost device-binding document (Heiko) > > Changes in v6: > - Rebase the Makefile/Kconfig files which add by Chris's rockchip-mipi driver (Caeser) > > Changes in v5: > - Use hdmi_infoframe helper functions to packed the infoframe (Russell) > - Remove the unused double wait_for_completion_timeout for ddc transfer (Russell) > - Remove the unused local variable in "inno_hdmi_i2c_write()" function (Russell) > > Changes in v4: > - Modify the commit title "drm/rockchip: hdmi: ..." (Mark) > - Correct the "DKMS" to "DPMS" (Mark) > - Fix over 80 characters problems (Mark) > - Remove encoder .prepare/.commit helper functions, and move the vop mode > configure function into encoder .enable helper functions. (Mark) > > Changes in v3: > - Use encoder enable/disable function, and remove the encoder DPMS function > - Keep HDMI PLL power on in standby mode > > Changes in v2: > - Using DRM atomic helper functions for connector init (Mark) > - Remove "hdmi->connector.encoder = encoder;" (Mark) > - Add the Acked-by tags from Rob > - Correct the misspell "rk3036-dw-hdmi" (Heiko) > > Yakir Yang (2): > drm/rockchip: hdmi: add Innosilicon HDMI support > dt-bindings: add document for Innosilicon HDMI on Rockchip platform > > .../display/rockchip/inno_hdmi-rockchip.txt | 50 ++ > drivers/gpu/drm/rockchip/Kconfig | 8 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/inno_hdmi.c | 939 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/inno_hdmi.h | 362 ++++++++ > 5 files changed, 1360 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h > Applied to my branch :-) . Thanks. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424936AbcBRGMS (ORCPT ); Thu, 18 Feb 2016 01:12:18 -0500 Received: from regular1.263xmail.com ([211.150.99.132]:51230 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424396AbcBRGMQ (ORCPT ); Thu, 18 Feb 2016 01:12:16 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <05a4edce8ab1a23f86291170abd36c1b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56C560B2.6020208@rock-chips.com> Date: Thu, 18 Feb 2016 14:12:02 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yakir Yang , Heiko Stuebner CC: David Airlie , Thierry Reding , Rob Herring , Ken Mixte , Ben Chan , Zheng Yang , Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 0/2] Add Rockchip Inno-HDMI driver References: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年01月29日 14:42, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: > - Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter > - Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec > - Digital video interface supports a pixel size of 24, 30, 36, 48bits color depth in RGB > - S/PDIF output supports PCM, Dolby Digital, DTS digital audio transmission > (32-192kHz Fs) using IEC60958 and IEC 61937 > - The EDID and CEC function are also supported by Innosilicon HDMI Transmitter Controlle > > Changes in v8: > - Don't check whether encoder output format is RGB colorspace, cause driver > default configure the output colorspace to RGB. (ZhengYang) > - Correct the check condition in inno_hdmi_config_video_csc() (ZhengYang) > - if (data->enc_out_format == data->enc_out_format) { > + if (data->enc_in_format == data->enc_out_format) { > > Changes in v7: > - Correct the module licnese statement (Paul) > - MODULE_LICENSE("GPL"); > + MODULE_LICENSE("GPLv2"); > - Start indentation with tabs and fix the misspell in Kconfig (Paul) > - Carry the lost device-binding document (Heiko) > > Changes in v6: > - Rebase the Makefile/Kconfig files which add by Chris's rockchip-mipi driver (Caeser) > > Changes in v5: > - Use hdmi_infoframe helper functions to packed the infoframe (Russell) > - Remove the unused double wait_for_completion_timeout for ddc transfer (Russell) > - Remove the unused local variable in "inno_hdmi_i2c_write()" function (Russell) > > Changes in v4: > - Modify the commit title "drm/rockchip: hdmi: ..." (Mark) > - Correct the "DKMS" to "DPMS" (Mark) > - Fix over 80 characters problems (Mark) > - Remove encoder .prepare/.commit helper functions, and move the vop mode > configure function into encoder .enable helper functions. (Mark) > > Changes in v3: > - Use encoder enable/disable function, and remove the encoder DPMS function > - Keep HDMI PLL power on in standby mode > > Changes in v2: > - Using DRM atomic helper functions for connector init (Mark) > - Remove "hdmi->connector.encoder = encoder;" (Mark) > - Add the Acked-by tags from Rob > - Correct the misspell "rk3036-dw-hdmi" (Heiko) > > Yakir Yang (2): > drm/rockchip: hdmi: add Innosilicon HDMI support > dt-bindings: add document for Innosilicon HDMI on Rockchip platform > > .../display/rockchip/inno_hdmi-rockchip.txt | 50 ++ > drivers/gpu/drm/rockchip/Kconfig | 8 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/inno_hdmi.c | 939 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/inno_hdmi.h | 362 ++++++++ > 5 files changed, 1360 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h > Applied to my branch :-) . Thanks. -- Ｍark Yao