From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1425191AbcBRGTe (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Feb 2016 01:19:34 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:62137 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1425148AbcBRGTd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Feb 2016 01:19:33 -0500
Subject: Re: [PATCH 07/54] perf tools: Enable BPF object configure syntax
To: Jiri Olsa <jolsa@redhat.com>
References: <1454680939-24963-1-git-send-email-wangnan0@huawei.com>
 <1454680939-24963-8-git-send-email-wangnan0@huawei.com>
 <20160212140945.GH16190@krava.redhat.com>
CC: Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Cody P Schafer" <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>,
        "He Kuang" <hekuang@huawei.com>,
        =?UTF-8?Q?J=c3=a9r=c3=a9mie_Galarneau?= 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, "Kirill Smelkov" <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, <pi3orama@163.com>,
        <linux-kernel@vger.kernel.org>
From: "Wangnan (F)" <wangnan0@huawei.com>
Message-ID: <56C561DE.5070700@huawei.com>
Date: Thu, 18 Feb 2016 14:17:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160212140945.GH16190@krava.redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.56C5620A.0057,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 4529ee255db6b5ecf43cb49b18927417
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/2/12 22:09, Jiri Olsa wrote:
> On Fri, Feb 05, 2016 at 02:01:32PM +0000, Wang Nan wrote:
>
> SNIP
>
>>   }
>>   |
>> -PE_BPF_SOURCE
>> +PE_BPF_SOURCE opt_event_config
>>   {
>>   	struct parse_events_evlist *data = _data;
>>   	struct list_head *list;
>>   
>>   	ALLOC_LIST(list);
>> -	ABORT_ON(parse_events_load_bpf(data, list, $1, true));
>> +	ABORT_ON(parse_events_load_bpf(data, list, $1, true, $2));
>> +	parse_events__free_terms($2);
>>   	$$ = list;
>>   }
>>   
>> +opt_event_config:
>> +'/' event_config '/'
>> +{
>> +	$$ = $2;
>> +}
>> +|
>> +{
>> +	$$ = NULL;
>> +}
> can't judge the bpf part, but for the parser part:
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>

You have already acked this patch before :)

Thank you.