From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod Date: Thu, 18 Feb 2016 13:15:25 +0530 Message-ID: <56C57695.3010300@ti.com> References: <1455773381-11839-1-git-send-email-j-keerthy@ti.com> <1455773381-11839-3-git-send-email-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Paul Walmsley , Keerthy Cc: tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org List-Id: linux-omap@vger.kernel.org Hi Paul, On Thursday 18 February 2016 12:12 PM, Paul Walmsley wrote: > Hi Keerthy > > On Thu, 18 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> No Public TRM is available for AM438x SoC as of now. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> index e97a894..fcffaf8 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { >> NULL, >> }; >> >> +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { >> + &am33xx_l4_wkup__rtc, >> + NULL, >> +}; >> + >> int __init am43xx_hwmod_init(void) >> { >> + int ret; >> + >> omap_hwmod_am43xx_reg(); >> omap_hwmod_init(); >> - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + >> + if (!(of_machine_is_compatible("ti,am438x"))) >> + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); >> + >> + return ret; >> } > > Could you please invert the test of this case such that the RTC hwmod is > only registered on AM43xx SoCs where it is specifically known to be > enabled? > > That way, if another AM43xx SoC comes out that doesn't have the RTC > module, it won't inadvertently be registered. This seems like a safer > approach. I get your point but currently only am438x SoC has RTC disabled forever. So i checked negating am438x. I can add a check with am4372 here and register for only those SoCs. I will resend a v2 in a while. Thanks for the quick response. Best Regards, Keerthy > > - Paul > From mboxrd@z Thu Jan 1 00:00:00 1970 From: a0393675@ti.com (Keerthy) Date: Thu, 18 Feb 2016 13:15:25 +0530 Subject: [PATCH 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod In-Reply-To: References: <1455773381-11839-1-git-send-email-j-keerthy@ti.com> <1455773381-11839-3-git-send-email-j-keerthy@ti.com> Message-ID: <56C57695.3010300@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On Thursday 18 February 2016 12:12 PM, Paul Walmsley wrote: > Hi Keerthy > > On Thu, 18 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> No Public TRM is available for AM438x SoC as of now. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> index e97a894..fcffaf8 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { >> NULL, >> }; >> >> +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { >> + &am33xx_l4_wkup__rtc, >> + NULL, >> +}; >> + >> int __init am43xx_hwmod_init(void) >> { >> + int ret; >> + >> omap_hwmod_am43xx_reg(); >> omap_hwmod_init(); >> - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + >> + if (!(of_machine_is_compatible("ti,am438x"))) >> + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); >> + >> + return ret; >> } > > Could you please invert the test of this case such that the RTC hwmod is > only registered on AM43xx SoCs where it is specifically known to be > enabled? > > That way, if another AM43xx SoC comes out that doesn't have the RTC > module, it won't inadvertently be registered. This seems like a safer > approach. I get your point but currently only am438x SoC has RTC disabled forever. So i checked negating am438x. I can add a check with am4372 here and register for only those SoCs. I will resend a v2 in a while. Thanks for the quick response. Best Regards, Keerthy > > - Paul > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933722AbcBRHp7 (ORCPT ); Thu, 18 Feb 2016 02:45:59 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:39522 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933423AbcBRHp5 (ORCPT ); Thu, 18 Feb 2016 02:45:57 -0500 Subject: Re: [PATCH 2/2] ARM: AM43XX: HWMOD: Add rtc hwmod To: Paul Walmsley , Keerthy References: <1455773381-11839-1-git-send-email-j-keerthy@ti.com> <1455773381-11839-3-git-send-email-j-keerthy@ti.com> CC: , , , , , From: Keerthy Message-ID: <56C57695.3010300@ti.com> Date: Thu, 18 Feb 2016 13:15:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Thursday 18 February 2016 12:12 PM, Paul Walmsley wrote: > Hi Keerthy > > On Thu, 18 Feb 2016, Keerthy wrote: > >> The patch adds rtc hwmod. RTC module The RTC module is physically >> present on the AM438x SoC used on AM43X-EPOS-EVM, but it is permanently >> disabled. A secure RTC is used instead on these devices, where needed. >> . Hence adding it selectively using a seprate list to get RTC Module >> functional on the other am43x SoCs used on am437x-gp-evm and >> am437x-sk-evm. >> >> Signed-off-by: Keerthy >> --- >> >> No Public TRM is available for AM438x SoC as of now. >> >> arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> index e97a894..fcffaf8 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c >> @@ -1020,9 +1020,21 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { >> NULL, >> }; >> >> +static struct omap_hwmod_ocp_if *am43xx_rtc_hwmod_ocp_ifs[] __initdata = { >> + &am33xx_l4_wkup__rtc, >> + NULL, >> +}; >> + >> int __init am43xx_hwmod_init(void) >> { >> + int ret; >> + >> omap_hwmod_am43xx_reg(); >> omap_hwmod_init(); >> - return omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + ret = omap_hwmod_register_links(am43xx_hwmod_ocp_ifs); >> + >> + if (!(of_machine_is_compatible("ti,am438x"))) >> + ret = omap_hwmod_register_links(am43xx_rtc_hwmod_ocp_ifs); >> + >> + return ret; >> } > > Could you please invert the test of this case such that the RTC hwmod is > only registered on AM43xx SoCs where it is specifically known to be > enabled? > > That way, if another AM43xx SoC comes out that doesn't have the RTC > module, it won't inadvertently be registered. This seems like a safer > approach. I get your point but currently only am438x SoC has RTC disabled forever. So i checked negating am438x. I can add a check with am4372 here and register for only those SoCs. I will resend a v2 in a while. Thanks for the quick response. Best Regards, Keerthy > > - Paul >