From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aWJYZ-0003k8-Do
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 03:03:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aWJYW-0007H1-7R
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 03:03:23 -0500
References: <1455259174-3384-1-git-send-email-den@openvz.org>
	<20160218051702.GA4440@grmbl.mre>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56C57ABC.5080207@openvz.org>
Date: Thu, 18 Feb 2016 11:03:08 +0300
MIME-Version: 1.0
In-Reply-To: <20160218051702.GA4440@grmbl.mre>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out
 of coroutine context
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>

On 02/18/2016 08:17 AM, Amit Shah wrote:
> Can someone from the block team please give this a review?
>
> Thanks,
>
> On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote:
>> There is a possibility to hit an assert in qcow2_get_specific_info that
>> s->qcow_version is undefined. This happens when VM in starting from
>> suspended state, i.e. it processes incoming migration, and in the same
>> time 'info block' is called.
>>
>> The problem is that qcow2_invalidate_cache() closes the image and
>> memset()s BDRVQcowState in the middle.
>>
>> This operation should not be performed in coroutine context.
>>
>> Changes from v1:
>> - fixed spelling. Eric, thank you for spell checking
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Juan Quintela <quintela@redhat.com>
>> CC: Amit Shah <amit.shah@redhat.com>
>>
> 		Amit
Paolo, can you pls bless this? I think that the fix comes from the
infrastructure layer and via your proposal.

Den