From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by gmr-mx.google.com with ESMTPS id 79si789378pft.0.2016.02.18.00.13.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 18 Feb 2016 00:13:28 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2Q00ICOHIB8J10@mailout1.w1.samsung.com> for rtc-linux@googlegroups.com; Thu, 18 Feb 2016 08:13:23 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings To: Valentin Rothberg , ldewangan@nvidia.com References: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> Cc: kbuild-all@01.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kbuild test robot From: Krzysztof Kozlowski Message-id: <56C57D1E.805@samsung.com> Date: Thu, 18 Feb 2016 17:13:18 +0900 MIME-version: 1.0 In-reply-to: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 18.02.2016 17:06, Valentin Rothberg wrote: > From: kbuild test robot > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > threaded IRQs without a primary handler need to be requested with > IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Valentin Rothberg > --- > drivers/rtc/rtc-max77686.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Nack, because: 1. AFAIR this is a false positive. 2. Was it tested? Was it reproduced? Was the bug actually spotted or just coccicheck pointed this and you assumed that "request will fail"? Coccicheck is a great tool... but not necessarily for pointing run-time bugs. Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425323AbcBRIN2 (ORCPT ); Thu, 18 Feb 2016 03:13:28 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:36089 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425300AbcBRIN0 (ORCPT ); Thu, 18 Feb 2016 03:13:26 -0500 X-AuditID: cbfec7f5-f79b16d000005389-35-56c57d232acf Subject: Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings To: Valentin Rothberg , ldewangan@nvidia.com References: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> Cc: kbuild-all@01.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kbuild test robot From: Krzysztof Kozlowski Message-id: <56C57D1E.805@samsung.com> Date: Thu, 18 Feb 2016 17:13:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e/4ZV3l2qNhBh9Oc1ksuXiV3aLj2mIm i+tfnrNavH++ntnizds1TBavXxhaHLs+kdli6b7VLBaXd81hs9jf2cFo0bRe0oHb4/5edo8n my4yeuyZeJLNY/Gel0wevc3v2Dy29N9l93h8+CS7R9+WVYwe0+f9ZPL4vEkugCuKyyYlNSez LLVI3y6BK6P94H72grfsFdfuPWRsYNzM1sXIySEhYCJxdPEpdghbTOLCvfVAcS4OIYGljBJ3 Z/1kh3CeMkqc/vyLBaRKWMBZYsPRS8wgtoiAl8Szy6eZQGwhAW+JjXt/M4E0MAu8YZS4Ne8L WBGbgLHE5uVLwNbxCqhJHFzeyAhiswioSlyf/R5stahAhMThzi52iBpBiR+T74Et4xTwkTjy +CNQPQfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5KzzXSK07M LS7NS9dLzs/dxAiJnK87GJceszrEKMDBqMTDu+HFkTAh1sSy4srcQ4wSHMxKIrzf3I+GCfGm JFZWpRblxxeV5qQWH2KU5mBREueduet9iJBAemJJanZqakFqEUyWiYNTqoFx/vWDqQbKwvt6 dC3V/CZ9PnjxnWHO0ucd2194PDjbvUXwY9r/3aUvtj1beDhT+KmP5I5Kwb3f6+/un14m1V26 T9X1ZMzHUosFPJ9mHenab6GedU+tpOCyu+efSO6MgC/S/J9OctvJFWg8fTx3Redri92tt29N DHqT4tm1jVfwiI5D2rOFyz06lViKMxINtZiLihMB/UgBtpgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.02.2016 17:06, Valentin Rothberg wrote: > From: kbuild test robot > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > threaded IRQs without a primary handler need to be requested with > IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Valentin Rothberg > --- > drivers/rtc/rtc-max77686.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Nack, because: 1. AFAIR this is a false positive. 2. Was it tested? Was it reproduced? Was the bug actually spotted or just coccicheck pointed this and you assumed that "request will fail"? Coccicheck is a great tool... but not necessarily for pointing run-time bugs. Best regards, Krzysztof