From: Michal Marek <mmarek@suse.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] kbuild: disable Android-specific compiler features
Date: Thu, 18 Feb 2016 10:36:03 +0100 [thread overview]
Message-ID: <56C59083.7060501@suse.com> (raw)
In-Reply-To: <CAGXu5jKOqnAGkpgr0iY47gFYAuJXQnsF5dQO655D00voVkX5UQ@mail.gmail.com>
Dne 18.2.2016 v 00:03 Kees Cook napsal(a):
> On Fri, Feb 5, 2016 at 4:44 PM, Kees Cook <keescook@chromium.org> wrote:
>> The Android compilers enable some non-standard features by default. While
>> most Android build systems inject the needed "-mno-android" option via
>> KCFLAGS, it happens too late (at least on x86_64), since KBUILD_CFLAGS
>> gains KCFLAGS after running (and failing) many cc-option tests. (For
>> example, the stack-protector tests happen after arch-specific
>> KBUILD_CFLAGS are added but before the external KCFLAGS are added.) As
>> such, we should notice this option and immediately turn it on as the
>> first cc-option test we run.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Michal, is this okay? I'd like to get it into -next soon if possible.
Is there a way to detect these compilers and are there some canonical
versions of these? I do not think it's a good idea to add workaround for
each random gcc fork.
Michal
next prev parent reply other threads:[~2016-02-18 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 0:44 [PATCH] kbuild: disable Android-specific compiler features Kees Cook
2016-02-17 23:03 ` Kees Cook
2016-02-18 9:36 ` Michal Marek [this message]
2016-02-18 17:54 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C59083.7060501@suse.com \
--to=mmarek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.