From: Gabor Juhos <juhosg@openwrt.org>
To: Alban <albeu@free.fr>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call
Date: Thu, 18 Feb 2016 11:05:35 +0100 [thread overview]
Message-ID: <56C5976F.9030904@openwrt.org> (raw)
In-Reply-To: <20160217134030.29e4c6d7@tock>
Hi Alban,
> On Wed, 17 Feb 2016 12:58:20 +0100
> Gabor Juhos <juhosg@openwrt.org> wrote:
>
>> The RB532 platform specific irq_to_gpio() implementation has been
>> removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of
>> custom gpio.h"). Now the platform uses the generic stub which causes
>> the following error:
>>
>> pata-rb532-cf pata-rb532-cf: no GPIO found for irq149
>> pata-rb532-cf: probe of pata-rb532-cf failed with error -2
>>
>> Drop the irq_to_gpio() call and get the GPIO number from platform
>> data instead. After this change, the driver works again:
>
> I think it would be preferable to move this driver to use the gpiod
> API. The changes needed should be about the same size and it would
> be a much more future proof fix.
The sole purpose of this patch is that to fix the breakage introduced in
832f5dacfa0b. Before that change, the driver was working without using the gpiod
API, and it is working again after this change.
Converting the driver to use the gpiod API needs more changes. Even if that is
preferable it should be implemented in separate patch(es) in my opinion.
-Gabor
next prev parent reply other threads:[~2016-02-18 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 11:58 [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call Gabor Juhos
2016-02-17 11:58 ` Gabor Juhos
2016-02-17 12:40 ` Alban
2016-02-17 12:40 ` Alban
2016-02-18 10:05 ` Gabor Juhos [this message]
2016-02-18 16:28 ` Tejun Heo
2016-02-18 16:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C5976F.9030904@openwrt.org \
--to=juhosg@openwrt.org \
--cc=albeu@free.fr \
--cc=arnd@arndb.de \
--cc=linux-ide@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.