From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQTx-0006xW-Ay for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWQTt-0003qb-7K for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:27:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQTt-0003qV-1K for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:27:01 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 7BC3870D6C for ; Thu, 18 Feb 2016 15:27:00 +0000 (UTC) References: <1455772616-8668-1-git-send-email-peterx@redhat.com> From: Paolo Bonzini Message-ID: <56C5E2BF.7040708@redhat.com> Date: Thu, 18 Feb 2016 16:26:55 +0100 MIME-Version: 1.0 In-Reply-To: <1455772616-8668-1-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 00/11] Add basic "detach" support for dump-guest-memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: famz@redhat.com, drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, lcapitulino@redhat.com On 18/02/2016 06:16, Peter Xu wrote: > Changes from v7: > - patch 8: use s->dump_info.page_size not TARGET_PAGE_SIZE > - patch 10: change DUMP_STATUS_MAX to DUMP_STATUS__MAX (this is to > fix compile error for rebasing to latest master branch, still do > not know why we need this change from generating "_MAX" to > "__MAX" for enum types...) It's because otherwise 'max' wouldn't be a valid value for an enum. :) Paolo > Changes from v6: > - patch 9: fix leak of local_err due to patch switch.. [Fam] > - patch 10: assert "result" before use [Fam] > - patch 11: add Fam's reviewed-by. > > For older patch, please refers to v6 series: > > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01299.html > > Peter Xu (11): > dump-guest-memory: cleanup: removing dump_{error|cleanup}(). > dump-guest-memory: add "detach" flag for QMP/HMP interfaces. > dump-guest-memory: using static DumpState, add DumpStatus > dump-guest-memory: add dump_in_progress() helper function > dump-guest-memory: introduce dump_process() helper function. > dump-guest-memory: disable dump when in INMIGRATE state > dump-guest-memory: add "detach" support > DumpState: adding total_size and written_size fields > Dump: add qmp command "query-dump" > Dump: add hmp command "info dump" > dump-guest-memory: add qmp event DUMP_COMPLETED > > docs/qmp-events.txt | 18 ++++ > dump.c | 215 ++++++++++++++++++++++++++++++---------- > hmp-commands-info.hx | 14 +++ > hmp-commands.hx | 5 +- > hmp.c | 26 ++++- > hmp.h | 1 + > include/qemu-common.h | 4 + > include/sysemu/dump.h | 15 +++ > include/sysemu/memory_mapping.h | 4 + > memory_mapping.c | 3 + > qapi-schema.json | 56 ++++++++++- > qapi/event.json | 16 +++ > qmp-commands.hx | 31 +++++- > qmp.c | 14 +++ > 14 files changed, 359 insertions(+), 63 deletions(-) >