All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: "Javier González" <jg@lightnvm.io>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH] lightnvm: do not reserve lun on l2p loading
Date: Thu, 18 Feb 2016 16:32:26 +0100	[thread overview]
Message-ID: <56C5E40A.50006@lightnvm.io> (raw)
In-Reply-To: <1455707783-31789-1-git-send-email-javier@javigon.com>

On 02/17/2016 12:16 PM, Javier González wrote:
> When the l2p table is loaded, addresses are checked for the lun they
> belong to and luns are reserved accordingly. This assumes that metadata
> is being stored in the backend device to recover the previous target
> configuration. Since this is not yet implemented, this check collides
> with some of the core initialization (e.g., sysblock initialization when
> a page is formed by several sectors).
>
> We take this check out and for now rely on that the right target will be
> created instead. When metadata is stored to recover a target, this check
> will come natural as aprt of the recovery strategy.
>
> FIXES c87ea75
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>   drivers/lightnvm/gennvm.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c
> index b97801c..42c1c2a 100644
> --- a/drivers/lightnvm/gennvm.c
> +++ b/drivers/lightnvm/gennvm.c
> @@ -192,9 +192,6 @@ static int gennvm_block_map(u64 slba, u32 nlb, __le64 *entries, void *private)
>   		lun_id = div_u64(pba, dev->sec_per_lun);
>   		lun = &gn->luns[lun_id];
>
> -		if (!test_bit(lun_id, dev->lun_map))
> -			__set_bit(lun_id, dev->lun_map);
> -
>   		/* Calculate block offset into lun */
>   		pba = pba - (dev->sec_per_lun * lun_id);
>   		blk = &lun->vlun.blocks[div_u64(pba, dev->sec_per_blk)];
>

Thanks Javier, applied.

-Matias

      reply	other threads:[~2016-02-18 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 11:16 [PATCH] lightnvm: do not reserve lun on l2p loading Javier González
2016-02-18 15:32 ` Matias Bjørling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5E40A.50006@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=javier@cnexlabs.com \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.