From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWRwb-0006bL-SD for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:00:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWRwY-0003qf-2t for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:00:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWRwX-0003q0-U2 for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:00:42 -0500 References: <1455778109-6278-1-git-send-email-eblake@redhat.com> <1455778109-6278-15-git-send-email-eblake@redhat.com> <87twl67ygg.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56C5F8B8.4000506@redhat.com> Date: Thu, 18 Feb 2016 10:00:40 -0700 MIME-Version: 1.0 In-Reply-To: <87twl67ygg.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="scXTwNmQoptsJ4WUX7RHg4mgx9CgtbGdF" Subject: Re: [Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen_visit_implicit_struct() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --scXTwNmQoptsJ4WUX7RHg4mgx9CgtbGdF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 09:52 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Delete code rendered dead in the previous patch. As explained >> there, we no longer have any need to use visit_start_struct(), >> and we no longer have any more code trying to create or use >> visit_type_implicit_FOO(). >> >> Signed-off-by: Eric Blake >=20 > The previous patch might be simple enough to permit squashing this one > in. Your choice. >=20 13/15: 6 files changed, 24 insertions(+), 42 deletions(-) 14/15: 5 files changed, 66 deletions(-) Yeah, squashing them makes for a more impressive diffstat, while still not being too overwhelming with too much done in one patch. I'm assuming you could handle the squashing as part of promoting to your qapi-next, if you want? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --scXTwNmQoptsJ4WUX7RHg4mgx9CgtbGdF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxfi4AAoJEKeha0olJ0Nq9o8H/RdxoRNi+oi8gA2pAOsJUaFQ 3ah1faljTMStcHp593UObU5KFBQ3Q0IW+nfR7d6nj7hEVppsw+39nTZfGyMiGVay 6wRoUVSh66MuFtwOZd2vEpTc0xDEjvcFD2XGvvcRpwdL3xz/tLqASSREw80UMdAX 14tq0SEGcnM5OErj7c8wYZ+DgtOtgwQD0o3A+SWojNc+DIO4UulkKJ05Q+y0Pi1z Vf1qo7Ql6BlKjShWLdkRTXwiKRWZVk8NHuR9ntP33xv/GN4U+xhc8t5O35D9GXMX pk4i+q1Ldg3jQZ4qTJqwWrLJnazq4KhaltI/QE/xFQONbGyPFkNFUFgLC60yOws= =L0Fh -----END PGP SIGNATURE----- --scXTwNmQoptsJ4WUX7RHg4mgx9CgtbGdF--