From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWSAg-0007Jk-Jk for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:15:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWSAd-0003jR-CJ for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:15:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWSAd-0003jG-6s for qemu-devel@nongnu.org; Thu, 18 Feb 2016 12:15:15 -0500 References: <1455031511-23684-1-git-send-email-peter.maydell@linaro.org> <1455031511-23684-4-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <56C5FC22.5040902@redhat.com> Date: Thu, 18 Feb 2016 10:15:14 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V5N3SjCnuIeKCdfTqx85NuaUBCeNdWuUt" Subject: Re: [Qemu-devel] [PATCH 03/14] disas/arm-a64.cc: Include osdep.h first List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: Patch Tracking This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V5N3SjCnuIeKCdfTqx85NuaUBCeNdWuUt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 08:49 AM, Peter Maydell wrote: > On 9 February 2016 at 15:25, Peter Maydell w= rote: >> Rearrange include directives so that we include osdep.h first. >> This has to be done manually because clean-includes doesn't >> handle C++. >> >> -#include "vixl/a64/disasm-a64.h" >> - >> extern "C" { >> +#include "qemu/osdep.h" >> #include "disas/bfd.h" >> } >> >> +#include "vixl/a64/disasm-a64.h" >> + >> using namespace vixl; >> >> static Decoder *vixl_decoder =3D NULL; >=20 > So this patch doesn't build on the old mingw32 compiler. I think this > is because this compiler is not C++11, and so its doesn't > provide various macros for C++ unless __STDC_CONSTANT_MACROS, > __STDC_LIMIT_MACROS and __STDC_FORMAT_MACROS are defined before the > first inclusion of . > (3) make osdep.h itself define the __STDC_* constants so it works > with C++-before-C++11 as well as with C and with C++11 >=20 > I think I prefer (3) (though it does mean we will have to tweak > osdep.h in future if a new vixl version should ever require any > further similar #defines.) (3) has my vote as well; it's the approach used by gnulib (wherever practical, do whatever wrapping it takes to make all standard headers appear like the most modern version of said header, even on older platfor= ms) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V5N3SjCnuIeKCdfTqx85NuaUBCeNdWuUt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxfwiAAoJEKeha0olJ0NqMLgH/3WT5wwbgC3rGlesVn56P3MD JOajV35SRECtI04l1ZZHurB3wb3ti7MILpN/NL9Gz4N+wXw5EowCQ3AjH4qrXcGe IBgwr/UriunBaekk9Uv4PLLuqz1yPfYN+Xy+4uaja2hSXj+bpGjTnQ5VVhxzrUTT pkR/Bo6wLyWU/Bl9rz5JDOEZED/KLckmSSStPx1kiyJ/HpKNatMsAVcBIDVLdFQr R+L4SW7dnrZhdRQNTv1zpcidM0yglsrouZFaWyVP3lZcZDok+VGWLACapZUH2MOD gwpKXqsKO9jZeZz8E6k0bSysLxSwYwz1qITwByDv5gYK5vWLGouLkMLB6XixKB0= =/Twc -----END PGP SIGNATURE----- --V5N3SjCnuIeKCdfTqx85NuaUBCeNdWuUt--