From: Hollis Blanchard <hollis_blanchard@mentor.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, crosthwaitepeter@gmail.com,
cov@codeaurora.org, lig.fnst@cn.fujitsu.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 2/2] generic-loader: Add a generic loader
Date: Thu, 18 Feb 2016 10:23:12 -0800 [thread overview]
Message-ID: <56C60C10.1070204@mentor.com> (raw)
In-Reply-To: <174e5d40f6c59bf57ea997c0575f21b8b67ce5d6.1455739133.git.alistair.francis@xilinx.com>
On 02/17/2016 01:04 PM, Alistair Francis wrote:
> +static void generic_loader_reset(DeviceState *dev)
> +{
> + GenericLoaderState *s = GENERIC_LOADER(dev);
> +
> + if (s->cpu) {
> + CPUClass *cc = CPU_GET_CLASS(s->cpu);
> + cpu_reset(s->cpu);
> + cc->set_pc(s->cpu, s->addr);
> + }
> +
> + if (s->data_len) {
> + dma_memory_write((s->cpu ? s->cpu : first_cpu)->as, s->addr, &s->data,
> + s->data_len);
> + }
> +}
What happens if I accidentally make "data-len" bigger than
sizeof(s->data)? I think some bounds checking is needed?
Hollis Blanchard
Mentor Graphics Emulation Division
next prev parent reply other threads:[~2016-02-18 18:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 21:04 [Qemu-devel] [PATCH v1 0/2] Add a generic loader Alistair Francis
2016-02-17 21:04 ` [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one Alistair Francis
2016-02-18 9:56 ` Markus Armbruster
2016-02-18 18:47 ` Alistair Francis
2016-02-18 21:47 ` Paolo Bonzini
2016-02-18 23:07 ` Peter Crosthwaite
2016-02-19 0:02 ` Alistair Francis
2016-02-19 9:33 ` Paolo Bonzini
2016-02-19 10:55 ` Peter Maydell
2016-02-19 17:17 ` Paolo Bonzini
2016-02-19 9:58 ` Markus Armbruster
2016-02-19 17:15 ` Andreas Färber
2016-02-19 18:53 ` Alistair Francis
2016-02-17 21:04 ` [Qemu-devel] [PATCH v1 2/2] generic-loader: Add a generic loader Alistair Francis
2016-02-17 21:41 ` Eric Blake
2016-02-18 0:03 ` Alistair Francis
2016-02-18 0:11 ` Eric Blake
2016-02-18 0:17 ` Alistair Francis
2016-02-18 18:23 ` Hollis Blanchard [this message]
2016-02-18 18:49 ` Alistair Francis
2016-02-18 18:58 ` Hollis Blanchard
2016-02-18 19:34 ` Alistair Francis
2016-02-18 18:27 ` [Qemu-devel] [PATCH v1 0/2] " Hollis Blanchard
2016-02-18 19:02 ` Alistair Francis
2016-02-18 20:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C60C10.1070204@mentor.com \
--to=hollis_blanchard@mentor.com \
--cc=alistair.francis@xilinx.com \
--cc=cov@codeaurora.org \
--cc=crosthwaitepeter@gmail.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.