From mboxrd@z Thu Jan 1 00:00:00 1970 From: ddaney@caviumnetworks.com (David Daney) Date: Thu, 18 Feb 2016 10:57:55 -0800 Subject: [PATCH v4 4/5] arm64/perf: Enable PMCR long cycle counter bit In-Reply-To: <20160218173428.GE16883@arm.com> References: <467597048eda3004bd69f1fbe3981aab111e00dd.1455810755.git.jglauber@cavium.com> <20160218173428.GE16883@arm.com> Message-ID: <56C61433.2090006@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/18/2016 09:34 AM, Will Deacon wrote: > On Thu, Feb 18, 2016 at 05:50:13PM +0100, Jan Glauber wrote: >> With the long cycle counter bit (LC) disabled the cycle counter is not >> working on ThunderX SOC (ThunderX only implements Aarch64). >> Also, according to documentation LC == 0 is deprecated. >> >> To keep the code simple the patch does not introduce 64 bit wide counter >> functions. Instead writing the cycle counter always sets the upper >> 32 bits so overflow interrupts are generated as before. >> >> Original patch from Andrew Pinksi > > What does this mean? Do we need Andrew's S-o-B, or is this a fresh patch? I don't believe we need Andrew's S-o-B as the assertion of the Developer's Certificate of Origin 1.1 clauses (a), (b) and (d) is being made. Specifically, clause (c) does not apply. However this may be a gray area, so we could put on Andrew's S-o-B if that would make everybody happier. David Daney > > Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947384AbcBRS6E (ORCPT ); Thu, 18 Feb 2016 13:58:04 -0500 Received: from mail-bl2on0100.outbound.protection.outlook.com ([65.55.169.100]:49604 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1946716AbcBRS6B (ORCPT ); Thu, 18 Feb 2016 13:58:01 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56C61433.2090006@caviumnetworks.com> Date: Thu, 18 Feb 2016 10:57:55 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon , "Pinski, Andrew" CC: Jan Glauber , Mark Rutland , , Subject: Re: [PATCH v4 4/5] arm64/perf: Enable PMCR long cycle counter bit References: <467597048eda3004bd69f1fbe3981aab111e00dd.1455810755.git.jglauber@cavium.com> <20160218173428.GE16883@arm.com> In-Reply-To: <20160218173428.GE16883@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0033.namprd07.prod.outlook.com (10.141.52.161) To BN4PR07MB2132.namprd07.prod.outlook.com (25.164.63.14) X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2132;2:tKJcd4uREG9Tq+e+NXhhSX0DOIjxArZ8mojZxpCITJcDrievjhddSlOIFrh6ZZvTxHkGi8QRwt4wuAKePUfu6crQz1NV+ASbOZ22XTtwRDTPc9dvBrt225ZexizLJzpZwJmNFKvLKZ71LPtzz7Nb8w==;3:Tu2gBp7tC2Bt9LPEkUXjbHipu/qaYs0xlZ+z/ZP2dRHDdRzACeFvj9pqJapT/+B1KFmHBx5eLsf8PE77sm3u93mVe84/k6wrLGhzYNCa3mbLq5NKV+bPZN+b+M/Pu0Pg;25:ME1mgqEcOCgENLgUyJlRHcosS4HLHdSNK/kUztO8oyZqfnWkjF/pHsqjI1oX8gfLhNxjfra4jsRiefUPuhpLOxm6D2hIuH2T19RqxBJsHErIG2a+xnPGhZTmRvJMQB8vEgKIm5dioLhkRYYX97HgfQ1AUbe706IvZNOXrU1LXleyaf+cFBe720qvZzu4hNtbkU3RVoqHKpifucAX6c2T0oUxYf2ySNEAY5ytMZ/s1klzqXs2WiFE11YP6dEzymoJb/pN3D4VwneYjXWb9RhVce33T9tkKgnanOV3bJc/LuPP6Vnah7/7VYI/f7fYHJqT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2132; X-MS-Office365-Filtering-Correlation-Id: e4bf770e-224f-4d9f-b07a-08d338956b3e X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2132;20:b4TgUyANQ/Kb8VywL8La8sztc0YlMMYLtsLzVzwMkqwvECmXolXAXxwmAt65NuUxWFGvqbi8JOOj9qukIDRAamgNt6ME3MNWBMG8tXUg0uKJ2Ry91TC4N2rOkJnC20m1kHeWTuJETHbxnpVC46aSjvdpNaLUSEX9mdqy07+H8HPlaFsQvHWJV98nJMe7vBAVyJa6rTjl0HGOOCawMmzJw3XHUWH5YpMd9Y4A+XLG+pFu8zXjAyvTRvZsCz36G7Tz1Q8pMhDXQR7HnNGteksxI14pzp23LX1VYl7pGRlQbH5LjRlr1r/GxVEOdRXfqSYPdNi9mZA64O5XLnHD0q8QufEFaPiZbCVRSFkSDxsfiCR2uysGbrGmuXYzBLZVS9EQ6GlQI+qXqeDrIv9Su4b6c78Hi9V62iMzPqeCeTg53Ltid7mszOqB2BvssOIqexmw33vBQXvxw2buzw6tpbytq5EuPOvrYsbyMPtr4/9kaQGmkInkJyObGDwRk5Tm2EY4BKk7dnuriYFqvQ+XGKtDTS4eP29nifXZEqLq6D8i/FotDJCIqCjLHi8H8aCjF3Yfx36SNY1+2EGjZS+LRSgguBqrLT01inqXV731Z9Iw6Wo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN4PR07MB2132;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2132; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2132;4:T1pFg/pSnt79P+StMuFHIfK0xL2ZFL2eRteRuIOzrc6NWvBC7VefaFH5NwG8s7MEX0xudnNMGvfv/cnDP8rb/uRuCbh26oMVzXZfgFHoHpud3fCSEOi4/PWxMRv0ro6SvPf7asAbuXINv1GPyn1xNJPoVafzwOBFKaSIQvmW5U9oSSuxZskXTSVrXHjlaTkq9ONlQB0wR++4Xfob10DdODK9LI9xr5YBSi4lx8qN58j7ebgtiZ+Zjnpgi3OijCMsV1QQo2DRe6XyYZZ1s9ofzC+bRphWfPvc1idoEvc/UF3NTPDbn8Gnx2d1cPvdIIoaRSgRVGmjbL8Q0dlawQ60TOHDC34sklzuNxC2rhZTc15nXilhbjWmj/hSivFnNSVh X-Forefront-PRVS: 085634EFF4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(479174004)(24454002)(377454003)(57704003)(189998001)(5004730100002)(2906002)(42186005)(33656002)(47776003)(66066001)(53416004)(586003)(36756003)(4001350100001)(6116002)(1096002)(65806001)(92566002)(50986999)(3846002)(5001770100001)(65956001)(4001450100002)(1720100001)(76176999)(4326007)(77096005)(54356999)(87266999)(230700001)(80316001)(19580405001)(19580395003)(65816999)(40100003)(122386002)(83506001)(15975445007)(5008740100001)(2950100001)(50466002)(5001960100002)(64126003)(23756003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2132;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2132;23:Zm9bP0wmZioz9K/6Gc/3oVFK5o1eJzcgzvdwgb5?= =?iso-8859-1?Q?Spfaj2xzRAGZAjqg7eOUj2az4TY9wMUDxz0xCt/eWbaBbTbetfxGkwNl6G?= =?iso-8859-1?Q?djPU/lxLoUoa1EIkZhSyDxgWUulaOb/bgsIpj7D4RN07Kuts+o1iv7i0Dp?= =?iso-8859-1?Q?us1dnxEzyGoy0QNezyczC6wQ3j9EcrA/GAoMDzjLjuLrfWSzYBY+iarLE+?= =?iso-8859-1?Q?NbN8zMjfv0WwwMqY9SPW+SJo9Ybde2Sfw51qcVRJPQQlvhMWsJBFK5DKwi?= =?iso-8859-1?Q?RE70JmwmI9Gc9Revsmasg8oZ+WOAQRCb+YnlnbkHS+qsUCyv2Hb/MiwISD?= =?iso-8859-1?Q?jWPPcFR3v29RrUO9GjMDZy5TX6kIsZmx3EHsaKLRGqfksJIdjNKQvvFIdO?= =?iso-8859-1?Q?UaP34T/g6jCAx2TZGZ84vs2ifwVRTJDwOhnwb3NqzK9hBKCcXQR4ubSpCF?= =?iso-8859-1?Q?yeAhrsKqEB7CQA+gcz1hBkZU0eY4SIOOTVTHZSIy/NNpcVdD1VqLadlMf+?= =?iso-8859-1?Q?Cn6CXFihniCCB39K2IC0AgWDVDMc60XTCZa/AqlCzMsVl+n2z2zW91J/5s?= =?iso-8859-1?Q?2ODSsHFZCeSb16eJGwUNzZF1tRO9czNiNqfRLx7gTI2Z5yt4n6PmtmDypu?= =?iso-8859-1?Q?WI0z4UjSpbS2vc3ftLNye3Q9PsdonpD84+5Qt34ROiIujaKDYxZ+9ENaIP?= =?iso-8859-1?Q?54IBXt4mpOBNosicVVDtuH//vgcl1rljrbCjEDVj/YHdYkca0h2kCzAFiy?= =?iso-8859-1?Q?G3zX3e3QdTF0nzfoygRBEi5Pno09G/juM/BCZzJhpgrEiU3/6rUBGOW3XH?= =?iso-8859-1?Q?UXXiX129BcicNElizIWt5kRMej9TVYDALE4S94QNh9GxEA4xZmLJ32WfDm?= =?iso-8859-1?Q?73IX6ndOTgQ3BTB/cEvY60+1G84NCxt3QZxFJV4PoGY64uC/FmBdWy6GGk?= =?iso-8859-1?Q?NEhmmxpehA8e6UHw5sZjr8tIGIKqgzZjdIVOAolFlvfu0r+IyhhY1LisT6?= =?iso-8859-1?Q?wVRKSgiscp4uGzCbT+BsxcYjtOjFdM4bSUfL7J0slUNdsoPlEhFghprvbi?= =?iso-8859-1?Q?pqPg+zKQnmKmfi/PnU9Epk+Y9vtxYT2pAVFG/jxiv7AahWoJ4GyWAaeIxZ?= =?iso-8859-1?Q?wx0Hr30YhqSYD13eWsmPR9SYYYkrfMopANYpiL2tSik3DDcpjA7JFkeyp6?= =?iso-8859-1?Q?jUKQakI1wL6hExLXAsdtO01vKf40vnxEByJD3RtqIHa5A0n5saGeAQm8wz?= =?iso-8859-1?Q?cdkYnUsBFNsMaxJeOoQnzxXsRswvWW6gnDwqlMg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2132;5:ws3E8jxh+UyE9+R0IEHCUah2E5P3+ecPqzp9Wnzjzw5R9EirLjMmwnewPQJ9QzuEZkDQyzoCGaOJBI0pjIdP1e1L4W+IaxEs7N4DdChiPgweAkhrO0Op+oMQzkv0DluHXP/Dufap//5Hmkhcb1wxiQ==;24:TABiMgJexzAug35qM3yaAleehjmutBRBNOiL3f6Ea1/zmrqSnKTqEUdNHdMNIGdZeez6S+zinN7kvWZ4/9Mj9S5FgyQkU756Vp7ieJjjCSE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2016 18:57:58.2112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2132 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/2016 09:34 AM, Will Deacon wrote: > On Thu, Feb 18, 2016 at 05:50:13PM +0100, Jan Glauber wrote: >> With the long cycle counter bit (LC) disabled the cycle counter is not >> working on ThunderX SOC (ThunderX only implements Aarch64). >> Also, according to documentation LC == 0 is deprecated. >> >> To keep the code simple the patch does not introduce 64 bit wide counter >> functions. Instead writing the cycle counter always sets the upper >> 32 bits so overflow interrupts are generated as before. >> >> Original patch from Andrew Pinksi > > What does this mean? Do we need Andrew's S-o-B, or is this a fresh patch? I don't believe we need Andrew's S-o-B as the assertion of the Developer's Certificate of Origin 1.1 clauses (a), (b) and (d) is being made. Specifically, clause (c) does not apply. However this may be a gray area, so we could put on Andrew's S-o-B if that would make everybody happier. David Daney > > Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >