From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWTwo-0003o9-8l for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:09:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWTwk-0004Za-1c for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:09:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWTwj-0004Yt-SM for qemu-devel@nongnu.org; Thu, 18 Feb 2016 14:09:01 -0500 References: <1455818725-7647-1-git-send-email-peter.maydell@linaro.org> <1455818725-7647-6-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <56C616CC.3030805@redhat.com> Date: Thu, 18 Feb 2016 12:09:00 -0700 MIME-Version: 1.0 In-Reply-To: <1455818725-7647-6-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ex2kEDtcK3O7cVlmvs6h8PguuM0nLL2Cr" Subject: Re: [Qemu-devel] [PATCH 5/8] scripts/clean-includes: Add --all option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ex2kEDtcK3O7cVlmvs6h8PguuM0nLL2Cr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 11:05 AM, Peter Maydell wrote: > Add a --all option which will run the script on every C > source and header file in the repository (except for those > in a few directories which contain standalone guest code). >=20 > Signed-off-by: Peter Maydell > --- > scripts/clean-includes | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > +# Regular expression defining files to ignore when using --all s/Regular/Extended regular/, to make it obvious which flavor we are using? (But yes to ERE; it's a pain to write \(..\|..\) in BRE). > +XDIRREGEX=3D'^(tests/tcg|tests/multiboot|pc-bios|disas/libvixl)' > + > if [ $# -ne 0 ] && [ "$1" =3D "--git" ]; then > =20 > +if [ "$1" =3D "--all" ]; then > + # We assume there are no files in the tree with spaces in their na= me > + set -- $(git ls-files '*.[ch]' | egrep -v "$XDIRREGEX") 'grep -E' is slightly more portable than 'egrep'. We could perhaps patch checkpatch.pl to enforce that no new files with stupid names are checked in... Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ex2kEDtcK3O7cVlmvs6h8PguuM0nLL2Cr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxhbMAAoJEKeha0olJ0Nqd0sIAIbqfO681H7WJVNK0asMDjL2 APY0VS9+7muBsi27m6LAiusk2/cdoL16Na2rkaYgFETth5Od3tKHd4vQnOuJ/wXv SbhqioSC5y7DJdAbo+9sS9+/XqL6euWjVD2fXpqlkC8S6ZCKK0rZB0P4JyTLVGCh wnAiCYXS6L8+Z9oKQiZx4eMxw/ConCx/DVKKCmzFdvq56jBXZcsMq+G5XVKFFu5g 2eIT/6l21yYBZh7gDh8icRRe6ozNJVzdJYlCP17vhlt8HzJZt/sBEHAP4Ly2efaJ uQBIpolJOzHicy5DqzfyDKAROv0uYmH7CslCON56PEchr3lyXdo/lNk4rqH4Ckw= =MdhF -----END PGP SIGNATURE----- --Ex2kEDtcK3O7cVlmvs6h8PguuM0nLL2Cr--